Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate Results 2 #60

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Intermediate Results 2 #60

merged 4 commits into from
Jul 10, 2023

Conversation

joshday
Copy link
Collaborator

@joshday joshday commented Jul 7, 2023

Okay, I think I've got this working for simulate with the following information being shared via RabbitMQ:

@joshday
Copy link
Collaborator Author

joshday commented Jul 7, 2023

Ref: #34

TODOs:

  • calibrate
  • ensemble (when it gets added)

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2023

Codecov Report

Merging #60 (e9421d1) into main (46f92d7) will increase coverage by 2.11%.
The diff coverage is 62.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   21.78%   23.89%   +2.11%     
==========================================
  Files          13       12       -1     
  Lines         280      318      +38     
==========================================
+ Hits           61       76      +15     
- Misses        219      242      +23     
Impacted Files Coverage Δ
src/contracts/Available.jl 18.18% <0.00%> (-1.82%) ⬇️
src/service/ArgIO.jl 2.22% <0.00%> (ø)
src/service/AssetManager.jl 1.81% <0.00%> (ø)
src/operations/Operations.jl 34.00% <47.22%> (-27.54%) ⬇️
src/contracts/ProblemInputs.jl 83.78% <100.00%> (+83.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

throw("ENSEMBLE IS NOT YET IMPLEMENTED")
end


# joshday: what is this function?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like it's just calibrate but with a global optimization done instead. It should instead just be an option in calibrate set by the context.

@@ -15,11 +15,11 @@ include("./AssetManager.jl"); import .AssetManager: fetch_dataset, fetch_model,
export prepare_input, prepare_output


"""
Transform requests into arguments to be used by operation
# """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come the docstrings are all commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were warnings about replaced docstrings when loading the package.

@fivegrant fivegrant merged commit 8e4dfc5 into main Jul 10, 2023
@fivegrant fivegrant deleted the jd/callbacks branch July 10, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants