-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediate Results 2 #60
Conversation
Ref: #34 TODOs:
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 21.78% 23.89% +2.11%
==========================================
Files 13 12 -1
Lines 280 318 +38
==========================================
+ Hits 61 76 +15
- Misses 219 242 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
throw("ENSEMBLE IS NOT YET IMPLEMENTED") | ||
end | ||
|
||
|
||
# joshday: what is this function? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like it's just calibrate
but with a global optimization done instead. It should instead just be an option in calibrate
set by the context.
@@ -15,11 +15,11 @@ include("./AssetManager.jl"); import .AssetManager: fetch_dataset, fetch_model, | |||
export prepare_input, prepare_output | |||
|
|||
|
|||
""" | |||
Transform requests into arguments to be used by operation | |||
# """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come the docstrings are all commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were warnings about replaced docstrings when loading the package.
Okay, I think I've got this working for
simulate
with the following information being shared via RabbitMQ:job_id
: The job id.iter
: Current iteration.time
: Current time.params
: Current parameter estimates.retcode
: (https://docs.sciml.ai/DiffEqDocs/stable/basics/solution/#retcodes) could possibly provide some useful information back to the user if things go wrong.