-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediate results loss reporting for Calibrate. Option for intermediate result reporting every integration step. #124
Intermediate results loss reporting for Calibrate. Option for intermediate result reporting every integration step. #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently we should remove any callback for simulate and focus solely on calibrate.
I added a few questions/comments.
src/operations.jl
Outdated
|
||
# callback for Simulate requests | ||
function get_callback(o::OperationRequest, ::Type{Simulate}) | ||
DiscreteCallback((args...) -> true, IntermediateResults(o.id,every_iteration = true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace every_iteration = true
with every=Dates.Second(0)
unnecessary. Moved callbacks. Turned off simulate intermediate reporting.
Adds callbacks for the solve of Calibrate so that optimization loss values and intermediate solutions can be reported. Added an option for intermediate results to be reported on every integration step instead of being time based. Added dispatches to the
get_callback
function to specialize on the type of the route inside of theOperationRequest
.