-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terarium dataservice migration changes #177
Conversation
* Update to use new data service endpoints * Using basic auth and snake case request headers.
* Correct casing
* Correct spacing
* Correct casing
* Updated docker compose
* Commenting out broken test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 81.78% 84.37% +2.59%
==========================================
Files 5 7 +2
Lines 505 845 +340
==========================================
+ Hits 413 713 +300
- Misses 92 132 +40 ☔ View full report in Codecov by Sentry. |
* Using TDS session
…-new-data-service # Conflicts: # worker/utils.py
* Moving to a common 'auth' file in lib
* No more username
…-new-data-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but I think some of the reporting changes to seeding may break the rest of the reporting flow.
@Sorrento110 and @fivegrant , how do we test the report generation on this branch? can one of you see if we've broken things before we merge this? |
@dgauldie |
The full flow has not been tested with this yet, however, the test container doesn't crash at least.
@dgauldie i just pushed a fix so the tests can run. reporting was broken because stuff was moved around at project root and data service was still being referenced in a few places. Seems to hang on seeding but the docker compose should be working for you now. It's because I have the wrong URL but you should be able to set everything up in .env to make it work |
This PR handles the changes needed to move to the new data service endpoints. This branch is untested currently, and contains the following changes:
kebab-case