Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

840 Fix asan issues and CI issues with return code #843

Merged
merged 7 commits into from
Jun 9, 2020

Conversation

lifflander
Copy link
Collaborator

@lifflander lifflander commented Jun 9, 2020

Fixes #840

Solve a bad lifetime access and a memory leak. #842 will be a more principled solution to the leak.

TODO:

  • Get CI to not pass ASAN failures

@lifflander lifflander changed the title 840 fix asan issues 840 Fix asan issues and CI issues with return code Jun 9, 2020
@lifflander lifflander marked this pull request as ready for review June 9, 2020 21:29
Copy link
Member

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, though you may want @pnstickne to look at this before merging

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #843 into develop will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #843      +/-   ##
===========================================
- Coverage    80.50%   80.50%   -0.01%     
===========================================
  Files          353      353              
  Lines        11205    11207       +2     
===========================================
+ Hits          9021     9022       +1     
- Misses        2184     2185       +1     
Impacted Files Coverage Δ
...erialization/messaging/serialized_messenger.impl.h 78.37% <0.00%> (-1.08%) ⬇️
src/vt/vrt/collection/manager.impl.h 85.01% <100.00%> (ø)
src/vt/vrt/proxy/base_collection_elm_proxy.h 100.00% <100.00%> (ø)
tests/unit/atomic/test_atomic.cc 100.00% <0.00%> (+1.31%) ⬆️

@lifflander lifflander merged commit 36a46a9 into develop Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix address sanitizer leaks and other issues for all examples/tests
2 participants