-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2340: Fix missing NumPy package #2341
Conversation
Pipelines resultsPR tests (gcc-12, ubuntu, mpich, verbose, kokkos) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-13, alpine, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (gcc-10, ubuntu, openmpi, no LB) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-9, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-11, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-12, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-13, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-14, ubuntu, mpich, verbose) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (clang-10, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (intel icpx, ubuntu, mpich, verbose) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (intel icpc, ubuntu, mpich) Build for ac48aee (2024-09-10 17:35:24 UTC)
PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose) Build for ac48aee (2024-09-10 17:35:24 UTC)
|
0039351
to
d221ae6
Compare
The issue was caused by a bug in DeepDiff v7. The NumPy dependency wasn't properly set up, so it wasn't installed, but it was required by a module from DeepDiff. After the change in the PR, the Docker image will be rebuilt, and the newest version of DeepDiff will be downloaded, which contains a bugfix for that issue. From the logs on develop, pushing a Docker image to Docker Hub seems to work correctly. |
5afc7ab
to
801daf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the problem on #2294
801daf7
to
d167cf4
Compare
This PR is not technically necessary to be merged. The new image was pushed from a modified CI run, and this change was needed as a trigger to rebuild the image. The PR only removes a duplicated entry for |
d167cf4
to
ac48aee
Compare
This PR contained an incidental fix that was not strictly necessary for fixing the missing numpy package. |
Fixes #2340