-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2212 add message properties for generated messages #2213
2212 add message properties for generated messages #2213
Conversation
Pipelines resultsPR tests (clang-11, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (clang-13, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (clang-14, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (clang-9, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (gcc-12, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (clang-10, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (clang-12, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (gcc-10, ubuntu, openmpi, no LB) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (intel icpc, ubuntu, mpich) Build for ae4bae5 (2023-11-29 23:45:07 UTC)
PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for e38bed2 (2023-11-30 01:26:26 UTC)
PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich) Build for e38bed2 (2023-11-30 01:26:26 UTC)
|
6e936ce
to
e462b54
Compare
dc52a6e
to
e7efdac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #2212
ParamMsg
from the constructor to a methodsetParams
so I could safely modify the message isMsgProps
are passed. Otherwise, I would have to save theMsgProps
to apply them after the constructor finishes.