Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2144: Fix unwanted cache export #2152

Merged
merged 3 commits into from
May 31, 2023
Merged

#2144: Fix unwanted cache export #2152

merged 3 commits into from
May 31, 2023

Conversation

thearusable
Copy link
Contributor

Fixes #2144

@thearusable thearusable self-assigned this May 26, 2023
@thearusable thearusable changed the title #2144: Fix unwanted export of ccache usage #2144: Fix unwanted cache export May 26, 2023
@github-actions
Copy link

github-actions bot commented May 26, 2023

Pipelines results

PR tests (clang-9, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 801cbc4 (2023-05-31 15:51:55 UTC)

Compilation - successful

Testing - passed

Build log


@nlslatt
Copy link
Collaborator

nlslatt commented May 26, 2023

@thearusable What is the new behavior introduced by this PR? Does it avoid forcing ccache on the parent project but still use it for vt embedded in that other project's build?

@PhilMiller
Copy link
Member

@thearusable What is the new behavior introduced by this PR? Does it avoid forcing ccache on the parent project but still use it for vt embedded in that other project's build?

I realize reading this PR that I should have thought a bit more about what to say in opening this and DARMA-tasking/magistrate#302. It's one thing if vt or Magistrate uses ccache automatically when built on its own. When built as part of a larger project, it should build the same way the larger project does, and not try to customize things like that.

@thearusable
Copy link
Contributor Author

@nlslatt Yes. After the latest changes it will respect the CMAKE_CXX_COMPILER_LAUNCHER parameter. It will search for ccache only when it's not defined. In other cases it will respect whatever was set in CMAKE_CXX_COMPILER_LAUNCHER for this or parent project.

@thearusable thearusable force-pushed the 2144-fix-ccache-export branch from c57d408 to 801cbc4 Compare May 31, 2023 15:52
@thearusable
Copy link
Contributor Author

After update vt will only search for ccache in standalone mode when CMAKE_CXX_COMPILER_LAUNCHER is not defined.

Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@nlslatt nlslatt merged commit aa645bd into develop May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded vt as a subdirectory exports ccache usage to enclosing project
3 participants