-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2144: Fix unwanted cache export #2152
Conversation
Pipelines resultsPR tests (clang-9, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (clang-12, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (gcc-10, ubuntu, openmpi, no LB) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (clang-11, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (clang-13, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (clang-14, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (clang-10, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (gcc-12, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (intel icpc, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich) Build for 801cbc4 (2023-05-31 15:51:55 UTC)
|
@thearusable What is the new behavior introduced by this PR? Does it avoid forcing ccache on the parent project but still use it for vt embedded in that other project's build? |
I realize reading this PR that I should have thought a bit more about what to say in opening this and DARMA-tasking/magistrate#302. It's one thing if vt or Magistrate uses ccache automatically when built on its own. When built as part of a larger project, it should build the same way the larger project does, and not try to customize things like that. |
@nlslatt Yes. After the latest changes it will respect the CMAKE_CXX_COMPILER_LAUNCHER parameter. It will search for ccache only when it's not defined. In other cases it will respect whatever was set in CMAKE_CXX_COMPILER_LAUNCHER for this or parent project. |
c57d408
to
801cbc4
Compare
After update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Fixes #2144