#2147: fix incorrect order of parameters for call to beginProcessing #2148
Conversation
Pipelines resultsPR tests (gcc-12, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (clang-9, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (clang-13, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (clang-12, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (gcc-10, ubuntu, openmpi, no LB) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (clang-11, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (clang-14, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (clang-10, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (intel icpc, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for f8a80b5 (2023-05-18 19:59:16 UTC) PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich) Build for f8a80b5 (2023-05-18 19:59:16 UTC) |
| @@ -359,7 +359,7 @@ TraceProcessingTag Trace::beginProcessing( | |||
| ); | |||
|
|
|||
| if (theConfig()->vt_trace_memory_usage) { | |||
| addMemoryEvent(theMemUsage()->getFirstUsage()); | |||
| addMemoryEvent(theMemUsage()->getFirstUsage(), time); | |||
There was a problem hiding this comment.
I added this so that the recorded events would be consistent (otherwise it uses the current time)
| @@ -404,7 +404,7 @@ void Trace::endProcessing( | |||
| ); | |||
|
|
|||
| if (theConfig()->vt_trace_memory_usage) { | |||
| addMemoryEvent(theMemUsage()->getFirstUsage()); | |||
| addMemoryEvent(theMemUsage()->getFirstUsage(), time); | |||
| /** | ||
| * \brief Get the number of recorded trace events | ||
| * | ||
| * \return the number of trace events | ||
| */ | ||
| std::size_t getNumTraceEvents() const { | ||
| return traces_.size(); | ||
| } | ||
|
|
||
| /** | ||
| * @brief Get the last recorded trace event | ||
| * | ||
| * @return the last recorded trace event | ||
| */ | ||
| const LogType* getLastTraceEvent() const noexcept { | ||
| return traces_.empty() ? nullptr : &traces_.back(); | ||
| } | ||
|
|
There was a problem hiding this comment.
These functions are mostly used for testing but might be useful in other circumstances
| @@ -349,7 +367,7 @@ struct TraceLite { | |||
| * | |||
| * \return computed bytes used for tracing (lower bound) | |||
| */ | |||
| std::size_t getTracesSize() const { | |||
| std::size_t getTracesSize() const noexcept { | |||
There was a problem hiding this comment.
I driveby-changed this to noexcept because it should be
|
Should the PR description be made a bit more comprehensive? |
|
Trivial remarks aside, this looks good to me. |
…time as the processing event
…alls to start() and finish() trace runnable components
nmm0
force-pushed
the
2147-invalid-trace-timings
branch
from
f164f59 to
f8a80b5
Compare
Closes #2147
I'm going to see if it is possible to add some tests, since we don't have any trace tests.