Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2082: Allow for custom compiler version in NVCC builds #2103

Merged
merged 7 commits into from
May 10, 2023
Merged

2082: Allow for custom compiler version in NVCC builds #2103

merged 7 commits into from
May 10, 2023

Conversation

thearusable
Copy link
Contributor

Closes #2082

@thearusable thearusable self-assigned this Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited
Loading

Pipelines results

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, gcc-9, ubuntu, mpich)

Build for 42899eb (2023-04-04 09:54:23 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 1d7f99b (2023-03-30 08:22:33 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 1d7f99b (2023-03-30 08:22:33 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 1d7f99b (2023-03-30 08:22:33 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for ad8dfbb (2023-05-10 08:39:04 UTC)

Compilation - successful

Testing - passed

Build log

@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch 2 times, most recently from 982eb83 to 7efacb7 Compare March 14, 2023 15:03
@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch 2 times, most recently from c5e638b to ceda80c Compare March 15, 2023 13:30
PhilMiller
PhilMiller reviewed Mar 21, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@nmm0 nmm0 mentioned this pull request Mar 21, 2023
Open
@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch from b67cb56 to 91ffdd1 Compare March 24, 2023 12:38
@thearusable thearusable changed the title 2082: Allow for custom compiler version in NVCC builds Draft: 2082: Allow for custom compiler version in NVCC builds Mar 24, 2023
@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch from 91ffdd1 to fd6fb01 Compare March 24, 2023 15:26
@thearusable thearusable changed the title Draft: 2082: Allow for custom compiler version in NVCC builds 2082: Allow for custom compiler version in NVCC builds Mar 28, 2023
@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch from fd6fb01 to 8c167ba Compare March 28, 2023 10:03
@thearusable thearusable requested a review from PhilMiller March 28, 2023 10:20
PhilMiller
PhilMiller reviewed Mar 28, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@PhilMiller
Copy link
Member

Looks like this effectvely incorporated #2116. That'll get merged and this can be rebased to not duplicate the changes.

@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch from 8c167ba to 7f31e00 Compare March 29, 2023 09:03
@PhilMiller PhilMiller mentioned this pull request Mar 29, 2023
Closed
@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch 3 times, most recently from c2f6067 to 42899eb Compare April 4, 2023 09:59
@thearusable thearusable requested a review from PhilMiller April 4, 2023 10:03
PhilMiller
PhilMiller reviewed Apr 4, 2023
View reviewed changes
ci/build_cpp.sh
# Match `nvcc_wrapper` and also a path ending with 'nvcc_wrapper'
case $CXX in
*nvcc_wrapper)
NVCC_WRAPPER_DEFAULT_COMPILER="$(which g++-"$(echo "${HOST_COMPILER}" | cut -d- -f2)")" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with Clang or Intel as the host compiler, but I don't think we care right now. Just noting it.

@thearusable thearusable mentioned this pull request Apr 11, 2023
Closed
@lifflander
Copy link
Collaborator

Let's rebase this and get it merged.

@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch from 42899eb to 70a55bc Compare May 4, 2023 08:26
@thearusable
Copy link
Contributor Author

Let's rebase this and get it merged.

@lifflander PR is now rebased and ready to merge.

cz4rs
cz4rs approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlslatt
Copy link
Collaborator

nlslatt commented May 9, 2023

@thearusable If you rebase this again, we can get it merged.

@thearusable thearusable force-pushed the 2082-fix-nvcc-pipeline branch from 70a55bc to ad8dfbb Compare May 10, 2023 08:39
@thearusable
Copy link
Contributor Author

@nlslatt Ok, rebased

@nlslatt nlslatt merged commit fd7501a into develop May 10, 2023
@cz4rs cz4rs mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@nmm0 nmm0 Awaiting requested review from nmm0

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@nlslatt nlslatt Awaiting requested review from nlslatt

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix nvcc builds
5 participants
@thearusable @PhilMiller @lifflander @nlslatt @cz4rs