Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2075: Update nvidia docker to use official image #2076

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

thearusable
Copy link
Contributor

@thearusable thearusable commented Jan 31, 2023

Closes #2075

@thearusable thearusable self-assigned this Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Pipelines results

PR tests (clang-10, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here-=-=%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.2, ubuntu, mpich)

Build for ( UTC)

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here-=-=%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 34003d1 (2023-02-21 09:40:49 UTC)

intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.-%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


@thearusable thearusable force-pushed the 2075-improve-dockerfile-for-cuda branch 2 times, most recently from 63750e5 to 0d69880 Compare February 3, 2023 13:38
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #2076 (67c8d43) into develop (893ca59) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 67c8d43 differs from pull request most recent head 34003d1. Consider uploading reports for the commit 34003d1 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2076      +/-   ##
===========================================
- Coverage    84.90%   84.87%   -0.04%     
===========================================
  Files          721      720       -1     
  Lines        25737    25638      -99     
===========================================
- Hits         21852    21759      -93     
+ Misses        3885     3879       -6     
Impacted Files Coverage Δ
...t/vrt/collection/balance/lb_data_restart_reader.cc 76.59% <0.00%> (-8.94%) ⬇️
src/vt/messaging/request_holder.h 69.23% <0.00%> (-7.70%) ⬇️
...vt/vrt/collection/balance/lb_data_restart_reader.h 78.57% <0.00%> (-7.15%) ⬇️
src/vt/context/runnable_context/lb_data.cc 68.42% <0.00%> (-1.58%) ⬇️
src/vt/context/runnable_context/trace.cc 70.00% <0.00%> (-1.43%) ⬇️
src/vt/scheduler/scheduler.cc 68.71% <0.00%> (-0.62%) ⬇️
src/vt/runnable/runnable.h 100.00% <0.00%> (ø)
src/vt/scheduler/scheduler.h 100.00% <0.00%> (ø)
src/vt/scheduler/base_unit.cc 100.00% <0.00%> (ø)
src/vt/runnable/make_runnable.h 100.00% <0.00%> (ø)
... and 5 more

@thearusable thearusable force-pushed the 2075-improve-dockerfile-for-cuda branch from 5f232c2 to 67c8d43 Compare February 10, 2023 16:51
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@thearusable thearusable force-pushed the 2075-improve-dockerfile-for-cuda branch from 67c8d43 to 34003d1 Compare February 21, 2023 09:41
@lifflander lifflander merged commit 64d3700 into develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use official Cuda docker image for azure pipelines
4 participants