Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2062 Fix duplicate symbols on some Mac builds #2065

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

nlslatt
Copy link
Collaborator

@nlslatt nlslatt commented Jan 13, 2023

Fixes #2062

Copy link
Member

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the discussion about this, and agree with the solution.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #2065 (9dd85f9) into develop (d0b2408) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2065      +/-   ##
===========================================
- Coverage    84.44%   84.43%   -0.02%     
===========================================
  Files          729      730       +1     
  Lines        25846    25842       -4     
===========================================
- Hits         21826    21820       -6     
- Misses        4020     4022       +2     
Impacted Files Coverage Δ
src/vt/pool/static_sized/memory_pool_equal.impl.h 100.00% <ø> (ø)
src/vt/runnable/runnable.cc 79.01% <ø> (ø)
src/vt/scheduler/suspended_units.cc 0.00% <0.00%> (-14.29%) ⬇️
src/vt/runtime/component/diagnostic.cc 50.00% <0.00%> (-2.95%) ⬇️
src/vt/trace/trace_user.cc 8.82% <0.00%> (-2.61%) ⬇️
src/vt/messaging/async_op.cc 66.66% <0.00%> (-2.57%) ⬇️
src/vt/rdma/collection/rdma_collection.cc 0.00% <0.00%> (-1.39%) ⬇️
src/vt/phase/phase_manager.cc 91.21% <0.00%> (-1.36%) ⬇️
src/vt/registry/auto/auto_registry.cc 71.42% <0.00%> (-0.99%) ⬇️
src/vt/rdma/rdma_handle.cc 72.41% <0.00%> (-0.92%) ⬇️
... and 22 more

@nlslatt nlslatt merged commit 9089be5 into develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix duplicate symbols on some Mac builds
2 participants