Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2030: Cleanup location management code #2031

Merged
merged 6 commits into from
Dec 1, 2022
Merged

Conversation

PhilMiller
Copy link
Member

@PhilMiller PhilMiller commented Dec 1, 2022

Grab the low-hanging bits from #1984 to merge now - everything I've posted here were changes that I reviewed in full and would approve there.

Fixes: #2030

@PhilMiller PhilMiller requested a review from lifflander December 1, 2022 01:57
@PhilMiller PhilMiller marked this pull request as draft December 1, 2022 01:57
@PhilMiller
Copy link
Member Author

PhilMiller commented Dec 1, 2022

At least one more commit to be pushed to this, pending local build and testing

@PhilMiller PhilMiller marked this pull request as ready for review December 1, 2022 02:27
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cz4rs
Copy link
Contributor

cz4rs commented Dec 1, 2022

@PhilMiller You need to (force) push again to trigger all builds after marking the PR as Ready for review.

@PhilMiller PhilMiller force-pushed the 2030-cleanup-location branch from 520d253 to d97316b Compare December 1, 2022 18:35
@lifflander lifflander merged commit 5dff872 into develop Dec 1, 2022
@PhilMiller PhilMiller deleted the 2030-cleanup-location branch December 1, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up location manager in advance of optimizations
3 participants