Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1987: LB: Rename LB Spec to LB Config #1989

Merged
merged 2 commits into from
Oct 12, 2022
Merged

1987: LB: Rename LB Spec to LB Config #1989

merged 2 commits into from
Oct 12, 2022

Conversation

JacobDomagala
Copy link
Contributor

Fixes #1987

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-5, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 6a0515d

Compilation - successful

Testing - passed

Build log


@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1989 (887a729) into develop (bd9a23f) will decrease coverage by 0.01%.
The diff coverage is 86.77%.

❗ Current head 887a729 differs from pull request most recent head 6a0515d. Consider uploading reports for the commit 6a0515d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1989      +/-   ##
===========================================
- Coverage    84.38%   84.36%   -0.02%     
===========================================
  Files          730      730              
  Lines        25644    25569      -75     
===========================================
- Hits         21640    21572      -68     
+ Misses        4004     3997       -7     
Impacted Files Coverage Δ
src/vt/configs/arguments/app_config.h 100.00% <ø> (ø)
src/vt/runtime/runtime_banner.cc 65.50% <0.00%> (ø)
src/vt/vrt/collection/balance/baselb/baselb.h 100.00% <ø> (ø)
src/vt/vrt/collection/balance/greedylb/greedylb.h 100.00% <ø> (ø)
.../vt/vrt/collection/balance/hierarchicallb/hierlb.h 100.00% <ø> (ø)
.../vt/vrt/collection/balance/lb_invoke/lb_manager.cc 79.61% <0.00%> (ø)
...rc/vt/vrt/collection/balance/offlinelb/offlinelb.h 0.00% <0.00%> (ø)
src/vt/vrt/collection/balance/randomlb/randomlb.h 100.00% <ø> (ø)
src/vt/vrt/collection/balance/rotatelb/rotatelb.h 100.00% <ø> (ø)
.../vt/vrt/collection/balance/temperedlb/temperedlb.h 100.00% <ø> (ø)
... and 34 more

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nlslatt nlslatt merged commit 37c6d74 into develop Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change wording of "LB Specification File" to "LB Config File"
3 participants