Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1942 improve efficiency of epoch stack #1979

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

stmcgovern
Copy link
Contributor

Closes #1942. Call propagateEpoch only when isActive is true.

@stmcgovern stmcgovern linked an issue Sep 23, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Sep 23, 2022

Pipelines results

PR tests (gcc-5, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-3.9, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 9fcbb7a

Compilation - successful

Testing - passed

Build log


@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1979 (9fcbb7a) into develop (741065e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1979      +/-   ##
===========================================
+ Coverage    84.29%   84.32%   +0.02%     
===========================================
  Files          728      728              
  Lines        25508    25508              
===========================================
+ Hits         21502    21509       +7     
+ Misses        4006     3999       -7     
Impacted Files Coverage Δ
src/vt/termination/term_state.cc 86.44% <100.00%> (-0.23%) ⬇️
src/vt/termination/term_state.h 100.00% <100.00%> (ø)
src/vt/termination/termination.cc 70.14% <100.00%> (ø)
src/vt/termination/termination.impl.h 97.87% <100.00%> (ø)
src/vt/vrt/collection/manager.impl.h 96.46% <0.00%> (+0.98%) ⬆️

@stmcgovern stmcgovern force-pushed the 1942-improve-efficiency-of-epoch-stack branch from 11cbf2d to 86278ca Compare September 27, 2022 21:56
@lifflander lifflander force-pushed the 1942-improve-efficiency-of-epoch-stack branch from 86278ca to 9fcbb7a Compare September 28, 2022 05:31
@lifflander lifflander merged commit 288d612 into develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve efficiency of epoch stack
2 participants