Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1958: lib: update googletest to 1.12.1 #1966

Merged
merged 2 commits into from
Oct 21, 2022
Merged

#1958: lib: update googletest to 1.12.1 #1966

merged 2 commits into from
Oct 21, 2022

Conversation

lifflander
Copy link
Collaborator

Fixes #1958

@lifflander lifflander linked an issue Sep 19, 2022 that may be closed by this pull request
Update GoogleTest (GTest) to at least 1.12.0 to get newer CMake dependency #1958
Closed
@github-actions
Copy link

github-actions bot commented Sep 19, 2022 •
edited
Loading

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for c894bf5 (2022-10-20 21:02:31 UTC)

Compilation - successful

Testing - passed

Build log

@nlslatt nlslatt force-pushed the 1958-update-googletest-gtest-to-at-least-1120-to-get-newer-cmake-dependency branch 2 times, most recently from b4fd5c6 to 3c4feeb Compare October 20, 2022 18:40
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #1966 (c894bf5) into develop (c9e686a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1966      +/-   ##
===========================================
+ Coverage    84.37%   84.39%   +0.01%     
===========================================
  Files          730      730              
  Lines        25632    25632              
===========================================
+ Hits         21628    21631       +3     
+ Misses        4004     4001       -3
Impacted Files Coverage Δ
tests/unit/collectives/test_mpi_collective.cc 99.32% <0.00%> (-0.68%) ⬇️
src/vt/phase/phase_manager.cc 92.56% <0.00%> (+2.70%) ⬆️

@nlslatt
Copy link
Collaborator

nlslatt commented Oct 20, 2022

My attempt to bump this to googletest main did not resolve the warning, so I propose we rebase out that commit and just hack the definition of GTEST_NO_TAIL_CALL_.

@nlslatt nlslatt marked this pull request as draft October 20, 2022 19:49
@nlslatt nlslatt force-pushed the 1958-update-googletest-gtest-to-at-least-1120-to-get-newer-cmake-dependency branch from 3c4feeb to 4528cd4 Compare October 20, 2022 20:54
@nlslatt nlslatt marked this pull request as ready for review October 20, 2022 21:03
@nlslatt
Copy link
Collaborator

nlslatt commented Oct 20, 2022

Looks like my hack eliminated the warnings. It would be great to get reviews.

@nlslatt nlslatt requested review from PhilMiller and cz4rs October 20, 2022 22:50
cz4rs
cz4rs approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nlslatt nlslatt merged commit 72e3a0a into develop Oct 21, 2022
@nmm0 nmm0 mentioned this pull request Oct 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@cz4rs cz4rs cz4rs approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

@nmm0 nmm0 Awaiting requested review from nmm0

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@nlslatt nlslatt Awaiting requested review from nlslatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GoogleTest (GTest) to at least 1.12.0 to get newer CMake dependency
7 participants
@lifflander @nlslatt @PhilMiller @stmcgovern @cz4rs @nmm0 @JacobDomagala