Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1839: use unsigned types for left shifts in BitPacker #1840

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

nmm0
Copy link
Collaborator

@nmm0 nmm0 commented Jun 1, 2022

fixes #1839

@nmm0 nmm0 linked an issue Jun 1, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Pipelines results

PR tests (gcc-5, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-3.9, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for 2b7e8cb

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for 121aa67

Compilation - successful

Testing - passed

Build log


@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1840 (f792858) into develop (f792858) will not change coverage.
The diff coverage is n/a.

❗ Current head f792858 differs from pull request most recent head 121aa67. Consider uploading reports for the commit 121aa67 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1840   +/-   ##
========================================
  Coverage    84.32%   84.32%           
========================================
  Files          757      757           
  Lines        26684    26684           
========================================
  Hits         22500    22500           
  Misses        4184     4184           

@nmm0 nmm0 requested review from nlslatt and lifflander June 1, 2022 22:27
@nmm0
Copy link
Collaborator Author

nmm0 commented Jun 1, 2022

I switch to std::memcpy instead of static_cast since that's the correct way of bit casting

@nmm0 nmm0 force-pushed the 1839-ub-left-shifting-negative-signed-values branch from 2b7e8cb to 121aa67 Compare June 2, 2022 22:37
@nmm0 nmm0 merged commit 31a7e33 into develop Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ub left shifting negative signed values
3 participants