Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1803 Concatenate compilation reports into one PR comment #1834

Merged
merged 2 commits into from
Jun 2, 2022
Merged

#1803 Concatenate compilation reports into one PR comment #1834

merged 2 commits into from
Jun 2, 2022

Conversation

jstrzebonski
Copy link
Contributor

Fixes #1803

@jstrzebonski jstrzebonski self-assigned this May 31, 2022
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for ed87229

Compilation - successful

Testing - passed

Build log

@codecov
Copy link

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #1834 (ed87229) into develop (4feceef) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1834      +/-   ##
===========================================
- Coverage    84.32%   84.30%   -0.02%     
===========================================
  Files          757      757              
  Lines        26685    26685              
===========================================
- Hits         22502    22498       -4     
- Misses        4183     4187       +4
Impacted Files Coverage Δ
src/vt/messaging/request_holder.h 69.23% <0.00%> (-7.70%) ⬇️
src/vt/phase/phase_manager.cc 92.43% <0.00%> (-1.69%) ⬇️

@jstrzebonski jstrzebonski force-pushed the 1803-concat-compilation-reports-into-one-comment branch from 0f1bb78 to dff50ad Compare May 31, 2022 11:39
@jstrzebonski jstrzebonski changed the title #1803 ensure there's no race condition when modyfing compilation result comment #1803 Concatenate compilation reports into one PR comment May 31, 2022
@jstrzebonski jstrzebonski marked this pull request as ready for review May 31, 2022 15:19
@nmm0 nmm0 mentioned this pull request May 31, 2022
Open
nmm0
nmm0 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

nlslatt
nlslatt approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good too

@jstrzebonski jstrzebonski force-pushed the 1803-concat-compilation-reports-into-one-comment branch from 85e2a9b to 0b41225 Compare June 2, 2022 06:24
cz4rs
cz4rs approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, way easier to follow the conversations now 👍

@nlslatt nlslatt force-pushed the 1803-concat-compilation-reports-into-one-comment branch from 0b41225 to ee11be2 Compare June 2, 2022 17:40
@jstrzebonski jstrzebonski force-pushed the 1803-concat-compilation-reports-into-one-comment branch from ee11be2 to ed87229 Compare June 2, 2022 17:44
@nlslatt nlslatt merged commit 3282949 into develop Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt approved these changes

@nmm0 nmm0 nmm0 approved these changes

@cz4rs cz4rs cz4rs approved these changes

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@lifflander lifflander Awaiting requested review from lifflander

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees

@jstrzebonski jstrzebonski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenate compilation reports into one PR comment
4 participants
@jstrzebonski @cz4rs @nmm0 @nlslatt