Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1513: fix "mallinfo is deprecated" warning #1798

Merged
merged 3 commits into from
May 17, 2022
Merged

1513: fix "mallinfo is deprecated" warning #1798

merged 3 commits into from
May 17, 2022

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented May 12, 2022

fixes #1513

@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #1798 (ca90cd4) into develop (ce6b977) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ca90cd4 differs from pull request most recent head 2749a65. Consider uploading reports for the commit 2749a65 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1798   +/-   ##
========================================
  Coverage    84.14%   84.15%           
========================================
  Files          753      753           
  Lines        26127    26126    -1     
========================================
+ Hits         21985    21986    +1     
+ Misses        4142     4140    -2
Impacted Files Coverage Δ
src/vt/utils/memory/memory_usage.cc 70.00% <100.00%> (-0.16%) ⬇️
src/vt/messaging/request_holder.h 76.92% <0.00%> (+7.69%) ⬆️

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (intel icpx, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@cz4rs cz4rs force-pushed the 1513-mallinfo-is-deprecated branch from 71c60fe to e0f3cec Compare May 12, 2022 16:56
@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-10, alpine, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-13, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-14, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-12, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-11, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-11, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (gcc-12, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for 2749a65

Compilation - successful

Testing - passed

Build log

@cz4rs cz4rs marked this pull request as ready for review May 12, 2022 17:41
@cz4rs cz4rs requested a review from stmcgovern May 12, 2022 17:41
@jstrzebonski
Copy link
Contributor

Besides the check_function_exists vs check_symbol_exists usage, that looks good.

@cz4rs cz4rs force-pushed the 1513-mallinfo-is-deprecated branch from ca90cd4 to 2749a65 Compare May 17, 2022 14:57
@PhilMiller PhilMiller merged commit 9946d16 into develop May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@nlslatt nlslatt Awaiting requested review from nlslatt

@nmm0 nmm0 Awaiting requested review from nmm0

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning: 'mallinfo' is deprecated (memory_usage.cc)
3 participants
@cz4rs @jstrzebonski @PhilMiller