Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1782: fix dangling pointer warning #1783

Merged
merged 1 commit into from
May 11, 2022
Merged

1782: fix dangling pointer warning #1783

merged 1 commit into from
May 11, 2022

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented May 9, 2022

fixes #1782

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-12, ubuntu, mpich)

Build for 390319a

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-13, ubuntu, mpich)

Build for 390319a

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (intel icpx, ubuntu, mpich)

Build for 390319a

/vt/lib/EngFormat-Cpp/src/eng_format.cpp:144:15: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    if      ( std::isnan( value ) ) return "NaN";
              ^~~~~~~~~~~~~~~~~~~
/vt/lib/EngFormat-Cpp/src/eng_format.cpp:145:15: warning: comparison with infinity always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    else if ( std::isinf( value ) ) return "INFINITE";
              ^~~~~~~~~~~~~~~~~~~
2 warnings generated.

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-11, ubuntu, mpich)

Build for 390319a

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@jstrzebonski
Copy link
Contributor

jstrzebonski commented May 9, 2022 •
edited
Loading

@cz4rs @lifflander it seems that it might be a good idea to get back to issue #874 (Audit use of const& in interfaces).

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-14, ubuntu, mpich)

Build for 390319a

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-10, alpine, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

jstrzebonski
jstrzebonski approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-11, ubuntu, mpich)

Build for 390319a

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59,
                 from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (gcc-12, ubuntu, mpich)

Build for 390319a

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for 390319a

Compilation - successful

Testing - passed

Build log

@cz4rs cz4rs force-pushed the 1782-dangling-pointer-warning branch from 503ceec to 136f718 Compare May 9, 2022 19:17
@cz4rs
Copy link
Contributor Author

cz4rs commented May 9, 2022

Rebased on top of develop.

lifflander
lifflander approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cz4rs cz4rs force-pushed the 1782-dangling-pointer-warning branch from 136f718 to 31a9fcb Compare May 10, 2022 12:31
@lifflander lifflander mentioned this pull request May 10, 2022
Open
@cz4rs cz4rs force-pushed the 1782-dangling-pointer-warning branch from 31a9fcb to 78777f6 Compare May 10, 2022 19:08
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #1783 (dc04fdd) into develop (dc04fdd) will not change coverage.
The diff coverage is n/a.

❗ Current head dc04fdd differs from pull request most recent head 390319a. Consider uploading reports for the commit 390319a to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1783   +/-   ##
========================================
  Coverage    84.14%   84.14%           
========================================
  Files          753      753           
  Lines        26127    26127           
========================================
  Hits         21985    21985           
  Misses        4142     4142

@cz4rs cz4rs force-pushed the 1782-dangling-pointer-warning branch from 78777f6 to 390319a Compare May 11, 2022 17:04
@lifflander lifflander merged commit 4fd20e1 into develop May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstrzebonski jstrzebonski jstrzebonski approved these changes

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@lifflander lifflander lifflander approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@nlslatt nlslatt Awaiting requested review from nlslatt

@nmm0 nmm0 Awaiting requested review from nmm0

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dangling pointer warning (gcc-12)
5 participants
@cz4rs @jstrzebonski @PhilMiller @lifflander @JacobDomagala