1672: Implement the total work LB algorithm in TemperedLB #1695

cz4rs · 2022-03-08T14:11:04Z

codecov · 2022-03-11T16:47:22Z

Codecov Report

Merging #1695 (cba6a3f) into develop (69239db) will increase coverage by 0.00%.
The diff coverage is 88.34%.

@@            Coverage Diff            @@
##           develop    #1695    +/-   ##
=========================================
  Coverage    84.27%   84.27%            
=========================================
  Files          754      757     +3     
  Lines        26464    26611   +147     
=========================================
+ Hits         22302    22426   +124     
- Misses        4162     4185    +23

Impacted Files	Coverage Δ
src/vt/configs/arguments/app_config.h	`100.00% <ø> (ø)`
src/vt/runtime/runtime_banner.cc	`65.58% <ø> (ø)`
...vt/vrt/collection/balance/greedylb/greedylb_msgs.h	`100.00% <ø> (ø)`
...rt/collection/balance/hierarchicallb/hierlb_msgs.h	`100.00% <ø> (ø)`
...c/vt/vrt/collection/balance/lb_invoke/lb_manager.h	`100.00% <ø> (ø)`
src/vt/vrt/collection/balance/lb_type.h	`100.00% <ø> (ø)`
...rc/vt/vrt/collection/balance/model/comm_overhead.h	`100.00% <ø> (ø)`
...c/vt/vrt/collection/balance/model/composed_model.h	`100.00% <ø> (ø)`
src/vt/vrt/collection/balance/model/linear_model.h	`100.00% <ø> (ø)`
.../vt/vrt/collection/balance/model/multiple_phases.h	`100.00% <ø> (ø)`
... and 69 more

lifflander · 2022-03-23T05:58:20Z

Looks good so far!

src/vt/vrt/collection/balance/model/load_model.h

src/vt/elm/elm_stats.h

github-actions · 2022-05-31T12:42:30Z

Pipelines results

PR tests (gcc-5, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-3.9, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for cba6a3f

Compilation - successful

Testing - passed

Build log

This reverts commit 16a58cb.

nlslatt

Looks great

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch from 55ff1fa to ef95825 Compare March 10, 2022 14:48

cz4rs changed the title ~~[WIP] 1672: Implement the total work LB algorithm in TemperedLB~~ 1672: Implement the total work LB algorithm in TemperedLB Mar 10, 2022

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch 5 times, most recently from e8388c6 to 624855a Compare March 11, 2022 15:55

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch 4 times, most recently from 53549af to a3cbf75 Compare March 21, 2022 11:51

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch from 1f6ab28 to 2c57617 Compare March 22, 2022 12:49

PhilMiller reviewed Mar 30, 2022

View reviewed changes

src/vt/vrt/collection/balance/model/load_model.h Outdated Show resolved Hide resolved

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch 2 times, most recently from c75993f to 7a5f460 Compare April 6, 2022 16:31

cz4rs commented Apr 6, 2022

View reviewed changes

src/vt/elm/elm_stats.h Outdated Show resolved Hide resolved

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch 6 times, most recently from 99e30a3 to 0504aa9 Compare April 14, 2022 13:01

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch from 7810378 to d6a22d9 Compare April 14, 2022 19:01

cz4rs marked this pull request as ready for review April 19, 2022 13:42

cz4rs requested review from lifflander, nlslatt, PhilMiller and JacobDomagala April 19, 2022 13:43

cz4rs added 4 commits May 30, 2022 10:45

#1672: tests: add missing parentheses

48f23d8

#1672: tests: use getModeledLoad method

a4a6b23

#1672: fix merge conflicts

49a0012

#1672: tests: remove unused argument

12f5c6b

cz4rs force-pushed the 1672-implement-total-work-lb-algorithm branch from 719b127 to 12f5c6b Compare May 30, 2022 10:34

cz4rs added 2 commits May 30, 2022 13:34

#1672: tests: make sure that TemperedWMin is chosen

bcb1e84

#1672: tests: narrow down the assertions for test results

e481a3d

cz4rs added 2 commits May 31, 2022 15:15

#1672: fix formatting

e68ed98

#1672: lb: move CommMsg to baselb messages

f787829

DARMA-tasking deleted a comment from github-actions bot Jun 1, 2022

This was referenced Jun 1, 2022

fix subphases handling in getModeledComm #1835

Closed

move the implementation of getModeledComm into a separate load model #1837

Closed

move getModeledWork out of TemeperedWMin #1838

Closed

#1672: Revert "improve post-commit hooks"

cba6a3f

This reverts commit 16a58cb.

nlslatt approved these changes Jun 1, 2022

View reviewed changes

nlslatt merged commit c1b5f62 into develop Jun 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1672: Implement the total work LB algorithm in TemperedLB #1695

1672: Implement the total work LB algorithm in TemperedLB #1695

cz4rs commented Mar 8, 2022

codecov bot commented Mar 11, 2022 •

edited

Loading

lifflander commented Mar 23, 2022

github-actions bot commented May 31, 2022 •

edited

Loading

nlslatt left a comment

1672: Implement the total work LB algorithm in TemperedLB #1695

1672: Implement the total work LB algorithm in TemperedLB #1695

Conversation

cz4rs commented Mar 8, 2022

codecov bot commented Mar 11, 2022 • edited Loading

Codecov Report

lifflander commented Mar 23, 2022

github-actions bot commented May 31, 2022 • edited Loading

Pipelines results

nlslatt left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 11, 2022 •

edited

Loading

github-actions bot commented May 31, 2022 •

edited

Loading