Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1667 refactor config includes #1670

Merged
merged 8 commits into from
Feb 15, 2022
Merged

#1667 refactor config includes #1670

merged 8 commits into from
Feb 15, 2022

Conversation

jstrzebonski
Copy link
Contributor

Fixes #1667

@jstrzebonski jstrzebonski self-assigned this Feb 8, 2022
@jstrzebonski jstrzebonski marked this pull request as draft February 8, 2022 10:08
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@codecov
Copy link

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #1670 (67a9e57) into develop (c20e83c) will not change coverage.
The diff coverage is n/a.

❗ Current head 67a9e57 differs from pull request most recent head 8d7ce4a. Consider uploading reports for the commit 8d7ce4a to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1670   +/-   ##
========================================
  Coverage    83.52%   83.52%           
========================================
  Files          799      799           
  Lines        30909    30909           
========================================
  Hits         25818    25818           
  Misses        5091     5091
Impacted Files Coverage Δ
src/vt/collective/reduce/scoping/strong_types.h 100.00% <ø> (ø)
src/vt/configs/debug/debug_colorize.h 100.00% <ø> (ø)
src/vt/configs/debug/debug_print.h 100.00% <ø> (ø)
src/vt/configs/debug/debug_var_unused.h 100.00% <ø> (ø)
src/vt/configs/error/error.impl.h 100.00% <ø> (ø)
src/vt/configs/error/pretty_print_stack.h 100.00% <ø> (ø)
src/vt/configs/error/soft_error.h 90.00% <ø> (ø)
src/vt/runtime/runtime.cc 76.10% <ø> (ø)
src/vt/trace/trace_lite.h 100.00% <ø> (ø)
src/vt/utils/strong/strong_type.h 100.00% <ø> (ø)
... and 1 more

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (clang-10, alpine, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for 8d7ce4a

Compilation - successful

Testing - passed

Build log

@jstrzebonski jstrzebonski marked this pull request as ready for review February 8, 2022 11:54
@lifflander lifflander mentioned this pull request Feb 8, 2022
Open
@jstrzebonski jstrzebonski force-pushed the 1667-config-includes-refactoring branch from 79c486c to aeae094 Compare February 9, 2022 21:09
@jstrzebonski jstrzebonski force-pushed the 1667-config-includes-refactoring branch from aeae094 to 8d7ce4a Compare February 9, 2022 21:14
@PhilMiller PhilMiller mentioned this pull request Feb 15, 2022
Merged
@PhilMiller PhilMiller merged commit c7e7832 into develop Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@lifflander lifflander Awaiting requested review from lifflander

Assignees

@jstrzebonski jstrzebonski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore refactoring includes in config to minimize and simplfiy inclusions
2 participants
@jstrzebonski @PhilMiller