-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1570: Move LB stats out of BaseLB #1572
Conversation
PR tests (clang-10, ubuntu, mpich) Build for 65f9282
|
Codecov Report
@@ Coverage Diff @@
## develop #1572 +/- ##
===========================================
+ Coverage 82.96% 83.00% +0.03%
===========================================
Files 784 785 +1
Lines 29740 29742 +2
===========================================
+ Hits 24674 24687 +13
+ Misses 5066 5055 -11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I have concerns about the data fed into the reductions.
|
||
std::vector<LoadData> lstats; | ||
lstats.emplace_back(LoadData{lb::Statistic::P_l, total_load}); | ||
lstats.emplace_back(reduceVec(lb::Statistic::O_l, std::move(O_l))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at how this is calculated, I think it comes out equal to total_load
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will compute the statistics over the objects instead of reducing the statistics down to one quantity per rank. So it will have the proper cardinality and compute min/max over the objects not the processors.
cc119e2
to
65f9282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you addressed our comments
Fixes #1570