Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1162: Make vt_lb_enabled default ON in cmake #1171

Merged
merged 1 commit into from
Dec 3, 2020
Merged

1162: Make vt_lb_enabled default ON in cmake #1171

merged 1 commit into from
Dec 3, 2020

Conversation

JacobDomagala
Copy link
Contributor

Fixes #1162

cz4rs
cz4rs approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, it seems like it's already set to 1 / true everywhere else

@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #1171 (c3a2d1d) into develop (2237673) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1171   +/-   ##
========================================
  Coverage    79.59%   79.59%           
========================================
  Files          724      724           
  Lines        27776    27776           
========================================
+ Hits         22108    22109    +1     
+ Misses        5668     5667    -1
Impacted Files Coverage Δ
tests/unit/atomic/test_atomic.cc 100.00% <0.00%> (+1.31%) ⬆️

@lifflander lifflander mentioned this pull request Dec 1, 2020
Open
@lifflander lifflander self-requested a review December 2, 2020 21:07
lifflander
lifflander approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JacobDomagala JacobDomagala marked this pull request as ready for review December 2, 2020 21:08
@JacobDomagala JacobDomagala force-pushed the 1162-make-vt-lb-enabled-by-default branch from e867c02 to c3a2d1d Compare December 2, 2020 21:09
@JacobDomagala JacobDomagala merged commit fb330d6 into develop Dec 3, 2020
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make vt_lb_enabled default ON in cmake
3 participants
@JacobDomagala @lifflander @cz4rs