Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old, unused LB instrumentation data structures #992

Closed
lifflander opened this issue Aug 18, 2020 · 1 comment · Fixed by #1108
Closed

Remove old, unused LB instrumentation data structures #992

lifflander opened this issue Aug 18, 2020 · 1 comment · Fixed by #1108
Assignees

Comments

@lifflander
Copy link
Collaborator

lifflander commented Aug 18, 2020

Remove all the old load balancing infrastructure that is not used. When I started implementing LB, I sketched out some implementation in vt/src/vt/lb/*. I believe none of this code is active or used. Try to remove it and ensure none of it is used anywhere.

@JacobDomagala
Copy link
Contributor

It seems that only vt/src/vt/lb/migration/lb_migratable.h is used (HasMigrate struct is base struct for UntypedCollection) I suggest we either move the file or the HasMigrate struct declaration to vt/src/vt/vrt/collection* directory.

NOTE: There's mention of this interface in vt/src/vt/vrt/collection/types/migratable.h:91 together with explanation how it's supposed to be used. Not sure if we want to touch it, just wanted to point that out since there's @todo added to it.

What's your opinion @lifflander @PhilMiller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants