Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vt aborts when json file does not have metadata #2162

Closed
nlslatt opened this issue Jun 9, 2023 · 1 comment · Fixed by #2164
Closed

vt aborts when json file does not have metadata #2162

nlslatt opened this issue Jun 9, 2023 · 1 comment · Fixed by #2164
Assignees
@thearusable
Labels
type: bug

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Jun 9, 2023 •
edited
Loading

Describe the bug
The metadata block is listed as optional in the LBDatafile schema, but vt aborts if it is missing from the json file due to the following line in LBDataHolder::readMetadata():

auto metadata = j["metadata"];
@nlslatt nlslatt changed the title vt aborts when json file does not have phases metadata vt aborts when json file does not have metadata Jun 9, 2023
@nlslatt
Copy link
Collaborator Author

nlslatt commented Jun 9, 2023

I corrected the above description.

thearusable added a commit that referenced this issue Jun 13, 2023
@thearusable
#2162: Fix vt aborting when lb file dont have metadata
289d7f7
@thearusable thearusable mentioned this issue Jun 13, 2023
Merged
thearusable added a commit that referenced this issue Jun 13, 2023
@thearusable
#2162: Fix vt aborting when lb file dont have metadata
0c5298b
@cwschilly cwschilly mentioned this issue Jun 13, 2023
Open
thearusable added a commit that referenced this issue Jun 20, 2023
@thearusable
#2162: Fix vt aborting when lb file dont have metadata
e73ae4f
thearusable added a commit that referenced this issue Jun 20, 2023
@thearusable
#2162: Fix vt aborting when lb file dont have metadata
741ab5b
nlslatt added a commit that referenced this issue Jun 20, 2023
@nlslatt
Merge pull request #2164 from DARMA-tasking/2162-fix-metadata-optiona…
5e79e6e 
…lity

#2162: Fix vt aborting when lb file dont have metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2162: Fix vt aborting when lb file dont have metadata DARMA-tasking/vt
2 participants
@thearusable @nlslatt