Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sprintf warning on macOS #2125

Closed
stmcgovern opened this issue Mar 29, 2023 · 3 comments · Fixed by #2208
Closed

sprintf warning on macOS #2125

stmcgovern opened this issue Mar 29, 2023 · 3 comments · Fixed by #2208
Assignees
@thearusable
Labels
type: task

Comments

@stmcgovern
Copy link
Contributor

stmcgovern commented Mar 29, 2023 •
edited by nlslatt
Loading

What Needs to be Done?

When building on mac I am seeing a warning of 'sprintf' is deprecated
It recommends using snprintf .

Also might be useful to enable -Werror in macos builds.
@nmm0 nmm0 mentioned this issue Apr 4, 2023
Open
@nlslatt
Copy link
Collaborator

nlslatt commented Oct 3, 2023

Duplicate of DARMA-tasking/magistrate#311

@nlslatt nlslatt marked this as a duplicate of DARMA-tasking/magistrate#311 Oct 3, 2023
@nlslatt nlslatt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
@nlslatt
Copy link
Collaborator

nlslatt commented Oct 24, 2023

Reopening because there are uses of sprintf in vt itself as well:

src/vt/group/collective/group_info_collective.cc:703
src/vt/runtime/runtime.cc:254

@nlslatt nlslatt reopened this Oct 24, 2023
@nlslatt
Copy link
Collaborator

nlslatt commented Oct 24, 2023

@thearusable There are two more uses of sprintf in vt that we need fixed. Thanks!

thearusable added a commit that referenced this issue Oct 27, 2023
@thearusable
#2125: Fix sprintf warnings
9af506a
@thearusable thearusable mentioned this issue Oct 27, 2023
Merged
thearusable added a commit that referenced this issue Oct 30, 2023
@thearusable
#2125: Fix incorrect max buffer length
79728d2
thearusable added a commit that referenced this issue Oct 31, 2023
@thearusable
#2125: Fix sprintf warnings
b76351d
thearusable added a commit that referenced this issue Oct 31, 2023
@thearusable
#2125: Fix incorrect max buffer length
d596532
thearusable added a commit that referenced this issue Nov 7, 2023
@thearusable
#2125: Fix sprintf warnings
ec4052e
thearusable added a commit that referenced this issue Nov 7, 2023
@thearusable
#2125: Fix incorrect max buffer length
51da09c
nlslatt added a commit that referenced this issue Nov 7, 2023
@nlslatt
Merge pull request #2208 from DARMA-tasking/2125-remove-sprintf-warnings
dca2a02 
#2125: Fix sprintf warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2125: Fix sprintf warnings DARMA-tasking/vt
3 participants
@stmcgovern @thearusable @nlslatt