Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace detector library with C++17 #2046

Closed
cz4rs opened this issue Dec 20, 2022 · 2 comments · Fixed by #2120
Closed

Replace detector library with C++17 #2046

cz4rs opened this issue Dec 20, 2022 · 2 comments · Fixed by #2120
Assignees
@lifflander @nmm0 @thearusable
Labels
c++17 Things to be done once we can rely on C++17 support type: task

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Dec 20, 2022 •
edited by PhilMiller
Loading

What Needs to be Done?
Replace, as much as possible, use of detector with C++17 constructs.

If it is possible to get rid of it completely, remember to remove it from build scripts, CMake and documentation, and archive the repository as well.
@cz4rs cz4rs added type: task c++17 Things to be done once we can rely on C++17 support labels Dec 20, 2022
@nmm0 nmm0 self-assigned this Jan 17, 2023
@nmm0
Copy link
Collaborator

nmm0 commented Jan 17, 2023 •
edited
Loading

Our plan now is to clean up the detector code, move it into Magistrate, and deprecate the detector library since it will be completely redundant in C++20

@nmm0 nmm0 mentioned this issue Jan 17, 2023
Open
@lifflander lifflander self-assigned this Mar 28, 2023
@lifflander
Copy link
Collaborator

Actually, I'm going to take this since it's the only way to really fix the install problem in VT.

lifflander added a commit that referenced this issue Mar 28, 2023
@lifflander
#2046: build: remove detector as dependency
dcbdd31
@lifflander lifflander mentioned this issue Mar 28, 2023
Merged
@lifflander lifflander linked a pull request Mar 28, 2023 that will close this issue
#2046: build: remove detector as dependency #2120
Merged
lifflander added a commit that referenced this issue Mar 28, 2023
@lifflander
#2046: build: change how sample project is built
553a7b8
lifflander added a commit that referenced this issue Mar 28, 2023
@lifflander
#2046: build: more changes
932be54
lifflander added a commit that referenced this issue Mar 29, 2023
@lifflander
Merge pull request #2120 from DARMA-tasking/2046-replace-detector-lib…
6822a09 
…rary-with-c++17

#2046: build: remove detector as dependency
cz4rs pushed a commit that referenced this issue Mar 30, 2023
@lifflander @cz4rs
#2046: build: remove detector as dependency
254f00a
cz4rs pushed a commit that referenced this issue Mar 30, 2023
@lifflander @cz4rs
#2046: build: change how sample project is built
d6f8e05
cz4rs pushed a commit that referenced this issue Mar 30, 2023
@lifflander @cz4rs
#2046: build: more changes
eb98c7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifflander lifflander

@nmm0 nmm0

@thearusable thearusable

Labels
c++17 Things to be done once we can rely on C++17 support type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2046: build: remove detector as dependency DARMA-tasking/vt
4 participants
@lifflander @cz4rs @nmm0 @thearusable