Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve makeRunnable allocation performance #1899

Closed
3 tasks
lifflander opened this issue Aug 4, 2022 · 0 comments · Fixed by #1963
Closed
3 tasks

Improve makeRunnable allocation performance #1899

lifflander opened this issue Aug 4, 2022 · 0 comments · Fixed by #1963
Assignees
@lifflander @thearusable
Labels
type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

  • First do this
  • Then do that.
  • Also this other thing.

Is your feature request related to a problem? Please describe.

Describe potential solution outcome

Describe alternatives you've considered

Additional context
@lifflander lifflander self-assigned this Aug 4, 2022
lifflander added a commit that referenced this issue Aug 5, 2022
@lifflander
#1899: context: remove template from collection
f3f75c8
lifflander added a commit that referenced this issue Aug 5, 2022
@lifflander
#1899: util: implement unique ptr with pool
cdea85c
lifflander added a commit that referenced this issue Aug 5, 2022
@lifflander
#1899: util: use new memory pool
306b573
lifflander added a commit that referenced this issue Aug 5, 2022
@lifflander
#1899: context: combine SetContext and FromNode
a16320b
@lifflander lifflander mentioned this issue Aug 5, 2022
Closed
@lifflander lifflander linked a pull request Aug 5, 2022 that will close this issue
1899 improve makerunnable allocation performance #1900
Closed
@stmcgovern stmcgovern mentioned this issue Aug 16, 2022
Closed
@nmm0 nmm0 mentioned this issue Aug 16, 2022
Open
thearusable added a commit that referenced this issue Aug 23, 2022
@thearusable
#1899: Remove unnecessary namespace
c2af5bd
thearusable added a commit that referenced this issue Aug 23, 2022
@thearusable
#1899: Split array into separate variables for each context type
05579f9
@stmcgovern stmcgovern mentioned this issue Aug 23, 2022
Merged
thearusable added a commit that referenced this issue Aug 24, 2022
@thearusable
#1899: Don't add trace context when tracing is disabled
df61780
thearusable added a commit that referenced this issue Aug 24, 2022
@thearusable
#1899: Improve methods description in runnable.h
cbd764e
thearusable pushed a commit that referenced this issue Aug 24, 2022
@lifflander @thearusable
#1899: context: remove template from collection
ddaea94
thearusable pushed a commit that referenced this issue Aug 24, 2022
@lifflander @thearusable
#1899: util: implement unique ptr with pool
1a8b3eb
thearusable pushed a commit that referenced this issue Aug 24, 2022
@lifflander @thearusable
#1899: util: use new memory pool
483e980
thearusable pushed a commit that referenced this issue Aug 24, 2022
@lifflander @thearusable
#1899: context: combine SetContext and FromNode
539b0f3
thearusable added a commit that referenced this issue Aug 24, 2022
@thearusable
#1899: Remove unnecessary namespace
9b8c779
thearusable added a commit that referenced this issue Aug 24, 2022
@thearusable
#1899: Split array into separate variables for each context type
1be5323
thearusable added a commit that referenced this issue Aug 24, 2022
@thearusable
#1899: Don't add trace context when tracing is disabled
d5d91ff
thearusable added a commit that referenced this issue Aug 24, 2022
@thearusable
#1899: Improve methods description in runnable.h
1942c6b
thearusable pushed a commit that referenced this issue Aug 25, 2022
@lifflander @thearusable
#1899: context: remove template from collection
70b4402
thearusable pushed a commit that referenced this issue Aug 25, 2022
@lifflander @thearusable
#1899: util: implement unique ptr with pool
7e07313
thearusable pushed a commit that referenced this issue Aug 25, 2022
@lifflander @thearusable
#1899: util: use new memory pool
ade8a7e
thearusable pushed a commit that referenced this issue Aug 25, 2022
@lifflander @thearusable
#1899: context: combine SetContext and FromNode
a28d6d0
thearusable added a commit that referenced this issue Aug 25, 2022
@thearusable
#1899: Remove unnecessary namespace
5791a01
thearusable added a commit that referenced this issue Aug 25, 2022
@thearusable
#1899: Split array into separate variables for each context type
b4fc0f1
lifflander added a commit that referenced this issue Sep 27, 2022
@lifflander
#1899: runnable: try moving trace context section up to fix Mac bug
8568fb7
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: context: combine SetContext and FromNode
5b00e5d
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: context: remove template from collection
593411f
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: store contexts directly instead of using pointers
8fa47a4
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: fix TD construct/destruct
a9fdeff
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: remove Base class for contexts
0f2b241
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: allocate through pool
cf36923
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: use raw pointer for RunnableNew
60d8f47
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: fix linking problem
77c6b0c
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: switch to bare pointer
d1de6ad
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: registry: completely remove old manual registry
4419698
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: remove tag as a runnable parameter
3855d08
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: active: fix debug print
07842af
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: make message const& in builder
f89ef03
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: disable more fcontext code when compile-time disabled
8837c71
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: do not reference message to enqueue
436f06d
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: td: disable suspended epochs when fcontext is disabled
be236b9
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: td: take message by const&
5d0ae23
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: scheduler: don't transition to idle right away
1453590
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: scheduler: fix bad rebase with endif
eddd61c
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: add missing getter for trace context
481bf3e
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: fix missing endif from merge
33b9947
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: fix double free
8e585ba
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: stop accessing msg_ if const& is invalid
ae7a1cd
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: add missing end for continuation causing leak
660355e
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: envelope: fix bug with lack of epoch propagation on put messages
ff8f337 
This is a long-standing bug that started showing up with the changes
in #1899, making the runnable more
efficient. TestGroup.test_group_range_construct_2 was consistently
breaking on the gcc-8 build with address sanitizer. With extensive
debugging, I tracked this bug down to the lack of propagation of an
epoch on the remote group construction message when a rooted group is
constructed where the constructing node is not included. Additionally,
the group must be specified by a list (not a range). When these
conditions occur, the group manager sends the information about the
group to a remote node using a packed put, which uses the
`PayloadMessage`: namely, ` struct GroupListMsg :
GroupInfoMsg<GroupMsg<::vt::PayloadMessage>>`. The `PayloadMessage`,
using a default template parameter, uses a basic envelope which is not
large enough to store the epoch. Thus, it gets dropped. Therefore, the
test sometimes breaks because the group construction and following
broadcast escape the `runInEpochCollective` and the test condition
will fail sometimes as it races with the delivery of the group message
being broadcast to the group spanning tree.
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: TD: make testEpochTerminated print verbose (mis-marked)
1acc0c8
cz4rs pushed a commit that referenced this issue Sep 28, 2022
@lifflander @cz4rs
#1899: runnable: try moving trace context section up to fix Mac bug
1ab6920
@lifflander lifflander mentioned this issue Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifflander lifflander

@thearusable thearusable

Labels
type: task
Projects
None yet
Milestone
No milestone
2 participants
@lifflander @thearusable