Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in find_package_local #1159

Closed
nlslatt opened this issue Nov 24, 2020 · 1 comment · Fixed by #1160
Closed

Bugs in find_package_local #1159

nlslatt opened this issue Nov 24, 2020 · 1 comment · Fixed by #1160
Assignees

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Nov 24, 2020

Describe the bug
When find_package_local fails to find the package, the list of search paths that it prints is incorrect. The printing logic assumes that the ${pkg_name}_DIR variable was unchanged during the loop over potential subdirectories containing the needed cmake files, which is incorrect. Additionally, the subdirectory existence check includes an undefined variable, pkg_prefix.

To Reproduce
Steps to reproduce the behavior:

  1. Example/test/snippet of code that fails
  2. Compiler, platform, libraries
  3. Run command: number of processors, threading options, etc.
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • Supercomputer or desktop [e.g., Trinity, Sierra)
  • Compiler environment [e.g., clang-3.9, gcc8]
  • Libraries [e.g., mpich-2, openmpi)
  • Commit ID or release of VT [e.g., vt-1.0.0]

Additional context
Add any other context about the problem here.

@nlslatt
Copy link
Collaborator Author

nlslatt commented Nov 24, 2020

The same problem exists in checkpoint (see DARMA-tasking/magistrate#163).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant