Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementStats is leaking memory from previous phases #1122

Closed
lifflander opened this issue Oct 20, 2020 · 3 comments · Fixed by #1137
Closed

ElementStats is leaking memory from previous phases #1122

lifflander opened this issue Oct 20, 2020 · 3 comments · Fixed by #1137
Assignees
@nlslatt
Labels
type: bug

Comments

@lifflander
Copy link
Collaborator

Describe the bug
ElementStats inside collection elements is leaking memory.
@jstrzebonski
Copy link
Contributor

jstrzebonski commented Oct 31, 2020 •
edited
Loading

@lifflander could you describe the problem a bit more indepth? I tried to run all tests and examples with LeakSanitizer, but didn't get anything useful, and also running all example from collection with Valgrind didn't give me much :'- (

@PhilMiller
Copy link
Member

It's not leaking, it's just accumulating. We need to coordinate between @jstrzebonski and @nlslatt to avoid duplicate efforts

@nlslatt
Copy link
Collaborator

nlslatt commented Nov 2, 2020

@jstrzebonski I'll take care of this today.

@nlslatt nlslatt self-assigned this Nov 2, 2020
@jstrzebonski jstrzebonski removed their assignment Nov 2, 2020
nlslatt added a commit that referenced this issue Nov 3, 2020
@nlslatt
#1122: test: check for growth in stats data
9a1e208
@lifflander lifflander mentioned this issue Nov 3, 2020
Open
nlslatt added a commit that referenced this issue Nov 3, 2020
@nlslatt
#1122: collection: remove deprecated code
c99b70b
nlslatt added a commit that referenced this issue Nov 3, 2020
@nlslatt
#1122: test: account for next phase
b9fa069
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: make element stats use unordered map
d575694
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: expire unneeded stats
0496576
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: clean up extra output
c792e65
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: check for growth in stats data
18a5ef8
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: remove deprecated code
04ac5c5
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: account for next phase
e25050a
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: make element stats use unordered map
9cac029
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: expire unneeded stats
1d2054c
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: clean up extra output
7528a91
@nlslatt nlslatt mentioned this issue Nov 4, 2020
Merged
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: clean up extra output
af9552d
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: check for growth in stats data
4da537b
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: remove deprecated code
1c582fa
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: account for next phase
ba261ad
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: make element stats use unordered map
e94578a
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: collection: expire unneeded stats
2096140
nlslatt added a commit that referenced this issue Nov 4, 2020
@nlslatt
#1122: test: clean up extra output
e2f04a8
nlslatt added a commit that referenced this issue Nov 6, 2020
@nlslatt
#1122: collection: rename cleanup
4ff8dc9
nlslatt added a commit that referenced this issue Nov 6, 2020
@nlslatt
#1122: collection: rename for consistency
da88437
nlslatt added a commit that referenced this issue Nov 6, 2020
@nlslatt
#1122: test: expect different result without lb
beb19ae
nlslatt added a commit that referenced this issue Nov 6, 2020
@nlslatt
#1122: collection: touch new stats entries when advancing phase
ba94181
nlslatt added a commit that referenced this issue Nov 6, 2020
@nlslatt
#1122: test: update to reflect consistency in sizes
16b300d
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: test: check for growth in stats data
f40aec0
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: collection: remove deprecated code
41e8506
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: test: account for next phase
7425502
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: collection: make element stats use unordered map
92c5e4b
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: collection: expire unneeded stats
f49a2af
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: test: clean up extra output
2fc7cd5
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: collection: rename cleanup
6ef1750
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: collection: rename for consistency
007ae95
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: test: expect different result without lb
bfb71b6
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: collection: touch new stats entries when advancing phase
dff123d
nlslatt added a commit that referenced this issue Nov 18, 2020
@nlslatt
#1122: test: update to reflect consistency in sizes
fd5479f
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: test: check for growth in stats data
3a5f2b8
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: collection: remove deprecated code
ddd9704
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: test: account for next phase
d46758a
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: collection: make element stats use unordered map
b2f3085
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: collection: expire unneeded stats
d192eb8
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: test: clean up extra output
2489f06
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: collection: rename cleanup
de145bf
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: collection: rename for consistency
dee4fa3
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: test: expect different result without lb
1e3bd41
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: collection: touch new stats entries when advancing phase
bae318e
lifflander pushed a commit that referenced this issue Nov 29, 2020
@nlslatt @lifflander
#1122: test: update to reflect consistency in sizes
6224135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlslatt nlslatt

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1122 elementstats is leaking DARMA-tasking/vt
4 participants
@PhilMiller @lifflander @jstrzebonski @nlslatt