Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake reruns multiple times #1005

Open
lifflander opened this issue Aug 25, 2020 · 3 comments
Open

CMake reruns multiple times #1005

lifflander opened this issue Aug 25, 2020 · 3 comments
Assignees
@nmm0
Labels
pri: low type: bug

Comments

@lifflander
Copy link
Collaborator

Describe the bug
CMake has to run multiple times due to something in our configuration. Identify this problem and see if we can solve it.
@lifflander
Copy link
Collaborator Author

Also, this might be related, the git sha is generated by CMake into a header file that is included for printing at startup. But, this means that CMake has to re-run if anything happens to git (even a local change). I'm not sure how useful this feature is. Maybe we can get the git status outside of cmake?

@nmm0
Copy link
Collaborator

nmm0 commented Sep 22, 2020

@lifflander I just checked and that's right. It looks like the code for getting git information intentionally causes configure to re-run. I don't think that's needed so I can probably find a way around it

@lifflander lifflander mentioned this issue Sep 22, 2020
Open
nmm0 added a commit that referenced this issue Nov 10, 2020
@nmm0
#1005: remove the GetGitRevisionDescription.cmake configure_file to p…
ec87e48 
…revent it from causing cmake to re-run every time the git state has changed
nmm0 added a commit that referenced this issue Nov 10, 2020
@nmm0
#1005: cmake: cache compiler checks for warning flags
7512923
nmm0 added a commit that referenced this issue Nov 10, 2020
@nmm0
#1005: avoid re-running cmake when git info is obtained by reading di…
4112561 
…rectly from git files
nmm0 added a commit that referenced this issue Nov 10, 2020
@nmm0
#1005: print find_package_local info only if cmake's find_package wil…
de7f3ac 
…l actually run
@lifflander
Copy link
Collaborator Author

@nmm0 Hey, are you still working on this? Does the PR you opened (#1144) do anything useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmm0 nmm0

Labels
pri: low type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifflander @nmm0