#1839: use memcpy to bitcast back to a signed type

DARMA-tasking · Jun 1, 2022 · f431e16 · f431e16
1 parent 5cee0b5
commit f431e16
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/vt/utils/bits/bits_packer.impl.h b/src/vt/utils/bits/bits_packer.impl.h
@@ -125,8 +125,10 @@ BitPacker::setFieldDynamic(
   UnsignedBitField seg;
   // Static cast will not work for negative types if we end up with that
   std::memcpy(&seg, &segment, sizeof(UnsignedBitField));
-  auto bits = static_cast<BitField>(((seg << nbits) >> nbits) << start);
-  field = field | bits;
+  auto bits = ((seg << nbits) >> nbits) << start;
+  BitField field_bits;
+  std::memcpy(&field_bits, &bits, sizeof(BitField));
+  field = field | field_bits;
 }
 
 template <FieldType start, FieldType len, typename BitField>