Merge pull request #2257 from DARMA-tasking/2256-increase-time-sigfigs

#2256: timing: add more significant figures
DARMA-tasking · Mar 27, 2024 · e3f0eb9 · e3f0eb9
2 parents 26f702c + 5c7878a
commit e3f0eb9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/vt/timing/timing.h b/src/vt/timing/timing.h
@@ -75,7 +75,7 @@ struct formatter<::vt::TimeTypeWrapper> {
   auto format(::vt::TimeTypeWrapper const& t, FormatContext& ctx) {
     return fmt::format_to(
       ctx.out(), "{}",
-      to_engineering_string(t.seconds(), 3, eng_exponential, "s")
+      to_engineering_string(t.seconds(), 5, eng_exponential, "s")
     );
   }
 };

diff --git a/tests/unit/timing/test_timing.nompi.cc b/tests/unit/timing/test_timing.nompi.cc
@@ -54,37 +54,37 @@ using TestTiming = TestHarness;
 TEST_F(TestTiming, test_time_formatting) {
   {
     TimeType const t = TimeType{15664645.400691890716};
-    EXPECT_EQ(fmt::format("{}", t), "15.7e6 s");
+    EXPECT_EQ(fmt::format("{}", t), "15.665e6 s");
   }
 
   {
     TimeType const t = TimeType{4.0006918907165527344};
-    EXPECT_EQ(fmt::format("{}", t), "4.00e0 s");
+    EXPECT_EQ(fmt::format("{}", t), "4.0007e0 s");
   }
 
   {
     TimeType const t = TimeType{0.0691890716552734423};
-    EXPECT_EQ(fmt::format("{}", t), "69.2e-3 s");
+    EXPECT_EQ(fmt::format("{}", t), "69.189e-3 s");
   }
 
   {
     TimeType const t = TimeType{-0.0691890716552734423};
-    EXPECT_EQ(fmt::format("{}", t), "-69.2e-3 s");
+    EXPECT_EQ(fmt::format("{}", t), "-69.189e-3 s");
   }
 
   {
     TimeType const t = TimeType{0.0006918907165527344};
-    EXPECT_EQ(fmt::format("{}", t), "692e-6 s");
+    EXPECT_EQ(fmt::format("{}", t), "691.89e-6 s");
   }
 
   {
     TimeType const t = TimeType{0.0000006918907165527};
-    EXPECT_EQ(fmt::format("{}", t), "692e-9 s");
+    EXPECT_EQ(fmt::format("{}", t), "691.89e-9 s");
   }
 
   {
     TimeType const t = TimeType{3.14};
-    EXPECT_EQ(fmt::format("{}", t), "3.14e0 s");
+    EXPECT_EQ(fmt::format("{}", t), "3.1400e0 s");
   }
 }