#1024: Suggest switching away from explicit message instantiation to …

…the send/broadcast(Args...) version
DARMA-tasking · Oct 15, 2020 · d8f3802 · d8f3802
1 parent 489dc15
commit d8f3802
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 12 deletions.
diff --git a/src/vt/objgroup/proxy/proxy_objgroup.h b/src/vt/objgroup/proxy/proxy_objgroup.h
@@ -102,7 +102,8 @@ struct Proxy {
    * \param[in] msg raw pointer to the message
    */
   template <typename MsgT, ActiveObjType<MsgT, ObjT> fn>
-  [[deprecated("Use broadcastMsg instead")]]
+  [[deprecated("For simple create and broadcast message use broadcast(Args...),\
+   otherwise use broadcastMsg(MsgPtrThief)")]]
   void broadcast(MsgT* msg) const;
 
   /**
@@ -112,7 +113,8 @@ struct Proxy {
    * \param[in] msg managed pointer to the message
    */
   template <typename MsgT, ActiveObjType<MsgT, ObjT> fn>
-  [[deprecated("Use broadcastMsg instead")]]
+  [[deprecated("For simple create and broadcast message use broadcast(Args...),\
+   otherwise use broadcastMsg(MsgPtrThief)")]]
   void broadcast(MsgPtr<MsgT> msg) const;
 
   /**

diff --git a/src/vt/objgroup/proxy/proxy_objgroup_elm.h b/src/vt/objgroup/proxy/proxy_objgroup_elm.h
@@ -92,7 +92,8 @@ struct ProxyElm {
    * \param[in] msg raw pointer to the message
    */
   template <typename MsgT, ActiveObjType<MsgT, ObjT> fn>
-  [[deprecated("Use sendMsg instead")]]
+  [[deprecated("For simple create and send message use send(Args...),\
+   otherwise use sendMsg(MsgPtrThief)")]]
   void send(MsgT* msg) const;
 
   /**
@@ -102,7 +103,8 @@ struct ProxyElm {
    * \param[in] msg managed pointer to the message
    */
   template <typename MsgT, ActiveObjType<MsgT, ObjT> fn>
-  [[deprecated("Use sendMsg instead")]]
+  [[deprecated("For simple create and send message use send(Args...),\
+   otherwise use sendMsg(MsgPtrThief)")]]
   void send(MsgSharedPtr<MsgT> msg) const;
 
   /**

diff --git a/src/vt/vrt/collection/broadcast/broadcastable.h b/src/vt/vrt/collection/broadcast/broadcastable.h
@@ -63,10 +63,12 @@ struct Broadcastable : BaseProxyT {
   Broadcastable& operator=(Broadcastable const&) = default;
 
   template <typename MsgT, ActiveColTypedFnType<MsgT, ColT> *f>
-  [[deprecated("Use broadcastMsg instead")]]
+  [[deprecated("For simple create and broadcast message use broadcast(Args...),\
+   otherwise use broadcastMsg(MsgPtrThief)")]]
   messaging::PendingSend broadcast(MsgT* msg) const;
   template <typename MsgT, ActiveColTypedFnType<MsgT, ColT> *f>
-  [[deprecated("Use broadcastMsg instead")]]
+  [[deprecated("For simple create and broadcast message use broadcast(Args...),\
+   otherwise use broadcastMsg(MsgPtrThief)")]]
   messaging::PendingSend broadcast(MsgSharedPtr<MsgT> msg) const;
 
   /**
@@ -93,10 +95,12 @@ struct Broadcastable : BaseProxyT {
   messaging::PendingSend broadcast(Args&&... args) const;
 
   template <typename MsgT, ActiveColMemberTypedFnType<MsgT, ColT> f>
-  [[deprecated("Use broadcastMsg instead")]]
+  [[deprecated("For simple create and broadcast message use broadcast(Args...),\
+   otherwise use broadcastMsg(MsgPtrThief)")]]
   messaging::PendingSend broadcast(MsgT* msg) const;
   template <typename MsgT, ActiveColMemberTypedFnType<MsgT, ColT> f>
-  [[deprecated("Use broadcastMsg instead")]]
+  [[deprecated("For simple create and broadcast message use broadcast(Args...),\
+   otherwise use broadcastMsg(MsgPtrThief)")]]
   messaging::PendingSend broadcast(MsgSharedPtr<MsgT> msg) const;
 
   /**

diff --git a/src/vt/vrt/collection/send/sendable.h b/src/vt/vrt/collection/send/sendable.h
@@ -64,10 +64,12 @@ struct Sendable : BaseProxyT {
   void serialize(SerializerT& s);
 
   template <typename MsgT, ActiveColTypedFnType<MsgT,ColT> *f>
-  [[deprecated("Use sendMsg instead")]]
+  [[deprecated("For simple create and send message use send(Args...),\
+   otherwise use sendMsg(MsgPtrThief)")]]
   messaging::PendingSend send(MsgT* msg) const;
   template <typename MsgT, ActiveColTypedFnType<MsgT,ColT> *f>
-  [[deprecated("Use sendMsg instead")]]
+  [[deprecated("For simple create and send message use send(Args...),\
+   otherwise use sendMsg(MsgPtrThief)")]]
   messaging::PendingSend send(MsgSharedPtr<MsgT> msg) const;
 
   /**
@@ -91,10 +93,12 @@ struct Sendable : BaseProxyT {
   messaging::PendingSend send(Args&&... args) const;
 
   template <typename MsgT, ActiveColMemberTypedFnType<MsgT,ColT> f>
-  [[deprecated("Use sendMsg instead")]]
+  [[deprecated("For simple create and send message use send(Args...),\
+   otherwise use sendMsg(MsgPtrThief)")]]
   messaging::PendingSend send(MsgT* msg) const;
   template <typename MsgT, ActiveColMemberTypedFnType<MsgT,ColT> f>
-  [[deprecated("Use sendMsg instead")]]
+  [[deprecated("For simple create and send message use send(Args...),\
+   otherwise use sendMsg(MsgPtrThief)")]]
   messaging::PendingSend send(MsgSharedPtr<MsgT> msg) const;
 
   /**