Skip to content

Commit

Permalink
#962 tests- automaticlly scan immediate test directories in CMake
Browse files Browse the repository at this point in the history
- All (immediate) test directories are added in CMake instead of
  being manually specified. This reduces the chance of misplacing
  and expected resource.. such as 'context'.

- REMOVED the non-compiled / not-executed context tests.

  These tests are woefully out of date and fail to compile
  for multiple reasons. See #999.
  • Loading branch information
pnstickne committed Aug 23, 2020
1 parent afcba5f commit ca47bca
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 478 deletions.
52 changes: 21 additions & 31 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,39 +14,29 @@ set(PROJECT_TEST_UNIT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/unit)
set(PROJECT_TEST_PERF_DIR ${CMAKE_CURRENT_SOURCE_DIR}/perf)
set(PROJECT_GTEST_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/extern/googletest/googletest/include)

set(
PROJECT_PERF_TESTS
ping_pong
memory_checker
comm_cost_curve
)
function(subdirlist result curdir)
file(
GLOB children
LIST_DIRECTORIES true
RELATIVE ${curdir} ${curdir}/*
)
set(dirlist "")
foreach(child ${children})
if(IS_DIRECTORY ${curdir}/${child})
list(APPEND dirlist ${child})
endif()
endforeach()
set(${result} ${dirlist} PARENT_SCOPE)
endfunction()

set(
subdirlist(
UNIT_TEST_SUBDIRS_LIST
index
active
collection
collectives
epoch
pool
location
sequencer
termination
mapping
group
serialization
pipe
tls
timetrigger
atomic
memory
objgroup
runtime
scheduler
lb
trace
rdma
utils
${PROJECT_TEST_UNIT_DIR}
)

subdirlist(
PROJECT_PERF_TESTS
${PROJECT_TEST_PERF_DIR}
)

#
Expand Down
102 changes: 0 additions & 102 deletions tests/unit/context/context_vrt_test.extended.cc

This file was deleted.

112 changes: 0 additions & 112 deletions tests/unit/context/context_vrtmanager_test.extended.cc

This file was deleted.

Loading

0 comments on commit ca47bca

Please sign in to comment.