Skip to content

Commit

Permalink
#2094: Fix compile issues
Browse files Browse the repository at this point in the history
  • Loading branch information
JacobDomagala committed Nov 8, 2023
1 parent 19d9bc6 commit bda613f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions examples/hello_world/objgroup.cc
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ int main(int argc, char** argv) {
if (this_node == 0) {
using namespace ::vt::group::region;

List list(List::ListType{0, 2, 4});
proxy.broadcastToNodes<&MyObjGroup::handler>(std::move(list), 20, 40, 60);
Region::RegionUPtrType list = std::make_unique<List>(List::ListType{0, 2, 4});
proxy.broadcastToNodes<&MyObjGroup::handler>(std::move(list), 20, 40);
}
vt::theCollective()->barrier();

Expand Down
2 changes: 1 addition & 1 deletion src/vt/objgroup/proxy/proxy_objgroup.h
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ struct Proxy {
PendingSendType broadcastToGroup(GroupType type, Args&&... args) const;

template <auto fn, typename... Args>
PendingSendType broadcastToNodes(group::region::List&& nodes, Args&&... args) const;
PendingSendType broadcastToNodes(group::region::Region::RegionUPtrType&& nodes, Args&&... args) const;

/**
* \brief All-reduce back to this objgroup. Performs a reduction using
Expand Down
2 changes: 1 addition & 1 deletion src/vt/objgroup/proxy/proxy_objgroup.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Proxy<ObjT>::broadcastToGroup(GroupType type, Params&&... params) const{
template <typename ObjT>
template <auto f, typename... Params>
typename Proxy<ObjT>::PendingSendType
Proxy<ObjT>::broadcastToNodes(group::region::List&& nodes, Params&&... params) const{
Proxy<ObjT>::broadcastToNodes(group::region::Region::RegionUPtrType&& nodes, Params&&... params) const{
// TODO: Should we cache it?
const auto groupType = theGroup()->newGroup(std::move(nodes), [](GroupType type){});
return broadcastToGroup<f>(groupType, std::forward<Params>(params)...);
Expand Down

0 comments on commit bda613f

Please sign in to comment.