#1163: collective: remove redundant initialize() override

DARMA-tasking · Dec 16, 2020 · a5d79b3 · a5d79b3
1 parent 82110d1
commit a5d79b3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/vt/collective/startup.cc b/src/vt/collective/startup.cc
@@ -52,20 +52,16 @@ namespace vt {
 
 // vt::{initialize,finalize} for main ::vt namespace
 RuntimePtrType initialize(
-  int& argc, char**& argv, WorkerCountType const num_workers,
-  bool is_interop, MPI_Comm* comm
+  int argc, char** argv, WorkerCountType const num_workers,
+  bool is_interop /* = false */, MPI_Comm* comm /* = nullptr */
 ) {
   return CollectiveOps::initialize(argc,argv,num_workers,is_interop,comm);
 }
 
-RuntimePtrType initialize(int& argc, char**& argv, MPI_Comm* comm) {
-  bool const is_interop = comm != nullptr;
-  return CollectiveOps::initialize(argc,argv,no_workers,is_interop,comm);
-}
-
-RuntimePtrType initialize(MPI_Comm* comm) {
-  int argc = 0;
-  char** argv = nullptr;
+RuntimePtrType initialize(
+  int argc /* = 0 */, char** argv /* = nullptr */,
+  MPI_Comm* comm /* = nullptr */
+) {
   bool const is_interop = comm != nullptr;
   return CollectiveOps::initialize(argc,argv,no_workers,is_interop,comm);
 }

diff --git a/src/vt/collective/startup.h b/src/vt/collective/startup.h
@@ -51,11 +51,12 @@
 namespace vt {
 
 RuntimePtrType initialize(
-  int& argc, char**& argv, WorkerCountType const num_workers,
+  int argc, char** argv, WorkerCountType const num_workers,
   bool is_interop = false, MPI_Comm* comm = nullptr
 );
-RuntimePtrType initialize(int& argc, char**& argv, MPI_Comm* comm = nullptr);
-RuntimePtrType initialize(MPI_Comm* comm = nullptr);
+RuntimePtrType initialize(
+  int argc = 0, char** argv = nullptr, MPI_Comm* comm = nullptr
+);
 
 void finalize(RuntimePtrType in_rt);
 void finalize();