Skip to content

Commit

Permalink
#1024: Rename newly added communication type for collective bcast
Browse files Browse the repository at this point in the history
  • Loading branch information
JacobDomagala authored and Braden Mailloux committed Oct 15, 2020
1 parent 45b1a58 commit 67c1d94
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/md/node-stats.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ the code.
| 4 | `CommCategory::Broadcast` | A broadcast from a collection element to a whole collection (receive-side) |
| 5 | `CommCategory::CollectionToNodeBcast` | A broadcast from a collection element to all nodes (receive-side) |
| 6 | `CommCategory::NodeToCollectionBcast` | A broadcast from a node to a whole collection (receive-side) |
| 7 | `CommCategory::CollectiveNodeToCollectionEdges` | Collective broadcast from a node to all its edges (receive-side) |
| 7 | `CommCategory::CollectiveToCollectionBcast` | Collective 'broadcast' from every node to the local collection elements (receive-side) |

For all the broadcast-like edges, the communication logging will occur on the
receive of the broadcast side (one entry per broadcast recipient).
2 changes: 1 addition & 1 deletion src/vt/vrt/collection/balance/lb_comm.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ enum struct CommCategory : int8_t {
Broadcast = 4,
CollectionToNodeBcast = 5,
NodeToCollectionBcast = 6,
CollectiveNodeToCollectionEdges = 7
CollectiveToCollectionBcast = 7
};

inline NodeType objGetNode(ElementIDType const id) {
Expand Down
2 changes: 1 addition & 1 deletion src/vt/vrt/collection/balance/node_stats.cc
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ getRecvSendDirection(CommKeyType const& comm) {

// Comm stats are not recorded for collective bcast
// this case is just to avoid warning of not handled enum
case CommCategory::CollectiveNodeToCollectionEdges:
case CommCategory::CollectiveToCollectionBcast:
return std::make_pair(ElementIDType{}, ElementIDType{});
}

Expand Down
2 changes: 1 addition & 1 deletion src/vt/vrt/collection/manager.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ messaging::PendingSend CollectionManager::broadcastCollectiveMsgImpl(

#if vt_check_enabled(lblite)
msg->setLBLiteInstrument(instrument);
msg->setCat(balance::CommCategory::NodeToCollectionBcast);
msg->setCat(balance::CommCategory::CollectiveToCollectionBcast);
#endif

auto const cur_epoch = theMsg()->setupEpochMsg(msg);
Expand Down

0 comments on commit 67c1d94

Please sign in to comment.