Skip to content

Commit

Permalink
#249: location: remove entity unregistering on tests finalization
Browse files Browse the repository at this point in the history
  • Loading branch information
hobywan committed Feb 25, 2019
1 parent f9cbeb0 commit 62bc30c
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions tests/unit/location/test_location.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ TEST_F(TestLocation, test_register_and_get_entity) {
if (my_node == home) {
// only performed if getLocation is synchronous, i.e on home_node
EXPECT_TRUE(success);
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
}
}

Expand Down Expand Up @@ -108,8 +107,6 @@ TEST_F(TestLocation, test_register_and_get_multiple_entities) {
EXPECT_TRUE(success);
}
}
// finalize
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
}

TEST_F(TestLocation, test_unregister_multiple_entities) {
Expand Down Expand Up @@ -172,10 +169,6 @@ TEST_F(TestLocation, test_migrate_entity) {
EXPECT_TRUE(node == old_home or node == new_home);
});
}
// finalize
if (my_node == new_home) {
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
}
}

TEST_F(TestLocation, test_migrate_multiple_entities) {
Expand Down Expand Up @@ -216,10 +209,6 @@ TEST_F(TestLocation, test_migrate_multiple_entities) {
EXPECT_TRUE(success);
}
}
// finalize
if (my_node == next_node) {
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
}
}

TYPED_TEST_CASE_P(TestLocationRoute);
Expand Down Expand Up @@ -261,10 +250,6 @@ TYPED_TEST_P(TestLocationRoute, test_route_entity) {

EXPECT_EQ(msg_count, nb_nodes - 1);
}
// finalize
if (my_node == home) {
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
}
}

TYPED_TEST_P(TestLocationRoute, test_entity_cache_hits){
Expand All @@ -288,9 +273,7 @@ TYPED_TEST_P(TestLocationRoute, test_entity_cache_hits){

// finalize
if (my_node == home) {
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
EXPECT_EQ(nb_received, (nb_nodes - 1) * nb_rounds);
EXPECT_FALSE(locat::isCached(entity));
}
}

Expand Down Expand Up @@ -334,10 +317,8 @@ TYPED_TEST_P(TestLocationRoute, test_entity_cache_migrated_entity){

// finalize
if (my_node == new_home) {
vt::theLocMan()->virtual_loc->unregisterEntity(entity);
auto const min_expected_ack = (nb_nodes - 2) * nb_rounds;
EXPECT_TRUE(nb_received >= min_expected_ack);
EXPECT_FALSE(locat::isCached(entity));
}
}

Expand Down

0 comments on commit 62bc30c

Please sign in to comment.