Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3: Implement and bind data model classes #4

Merged
merged 14 commits into from
Jun 7, 2023
Merged

#3: Implement and bind data model classes #4

merged 14 commits into from
Jun 7, 2023

Conversation

pierrepebay
Copy link
Contributor

@pierrepebay pierrepebay commented Apr 24, 2023 •
edited
Loading

Fixes: #3

@pierrepebay pierrepebay linked an issue Apr 24, 2023 that may be closed by this pull request
Implement necessary vt-tv data model classes #3
Closed
1 task
@pierrepebay pierrepebay changed the title #3: Implement and bind block data model class Implement and bind data model classes Apr 24, 2023
@pierrepebay
Copy link
Contributor Author

Implemented Block data model class, needs type checking in constructor (using nanobind nb::type_error, as is used in detach_object_id).

@pierrepebay pierrepebay self-assigned this Apr 24, 2023
@pierrepebay pierrepebay changed the title Implement and bind data model classes #3: Implement and bind data model classes Apr 25, 2023
@pierrepebay pierrepebay force-pushed the 3-implement-necessary-vt-tv-data-model-classes branch from 55d1f22 to ec22645 Compare April 28, 2023 20:21
@pierrepebay
Copy link
Contributor Author

Current image output of example2, which reads data from tests/unit/lb_test_data/data.0.json:

The objects are scaled according to the load.

@ppebay
Copy link
Contributor

ppebay commented May 4, 2023

@pierrepebay a reference example (from the step.yaml case) regarding our discussion of 05/03 pertaining to the problem of linear scaling of surface area w.r.t. widely varying object loads (as opposed to, for instance, logarithmic scaling which could be added in the future):

step.mp4

Objects are present, and glyphed indeed in all phases, but hardly visible for phases post-initial one.

@pierrepebay
Copy link
Contributor Author

pierrepebay commented May 16, 2023 •
edited
Loading

When using the exported meshes in vtp in paraview, we can obtain a very simple first visualization:

Current vt-tv result when viewing in paraview current LBAF exported visualization

@pierrepebay
Copy link
Contributor Author

Current result with jitter:

@pierrepebay pierrepebay force-pushed the 3-implement-necessary-vt-tv-data-model-classes branch from 985e645 to ac2164f Compare May 30, 2023 22:23
@pierrepebay pierrepebay force-pushed the 3-implement-necessary-vt-tv-data-model-classes branch from 45190bc to 86eb679 Compare May 30, 2023 22:46
@pierrepebay pierrepebay marked this pull request as ready for review May 30, 2023 22:46
@pierrepebay
Copy link
Contributor Author

@lifflander this PR is now ready for review, object communications will be in an other issue/PR.

lifflander
lifflander requested changes May 31, 2023
View reviewed changes
examples/example2.cc Outdated Show resolved Hide resolved
lib_example.py Outdated Show resolved Hide resolved
src/vt-tv/render/render.h Outdated Show resolved Hide resolved
@nmm0 nmm0 mentioned this pull request Jun 6, 2023
Open
@pierrepebay
Copy link
Contributor Author

@lifflander I have addressed the requested changes, should be ready to merge!

@lifflander lifflander merged commit d406dd9 into master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@ppebay ppebay Awaiting requested review from ppebay

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees

@pierrepebay pierrepebay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement necessary vt-tv data model classes
3 participants
@pierrepebay @ppebay @lifflander