Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly generated PNG artifacts on MacOS #70

Open
ppebay opened this issue May 24, 2024 · 9 comments
Open

Incorrectly generated PNG artifacts on MacOS #70

ppebay opened this issue May 24, 2024 · 9 comments
Assignees
Labels
question Further information is requested

Comments

@ppebay
Copy link
Contributor

ppebay commented May 24, 2024

Steps to reproduce

  • on macOS 14.3, using Python 3.9.19 via conda and a build of VTK 9.3 from source;
  • execute LBAF with the test-vt-tv.yaml configuration file in order to exercise vt-tv.

Observed error

Incorrect and missing edges in PNG artifact:

output_file0

@ppebay ppebay added the bug Something isn't working label May 24, 2024
@lifflander
Copy link
Contributor

Test this on a Mac machine @pierrepebay

@pierrepebay
Copy link
Contributor

I have tested this on MacOS 13.5.2 with Python 3.9.19 and a build of VTK 9.3.0, here is the output:

output_file0

@ppebay ppebay added question Further information is requested Low priority To be addressed after high priority and removed bug Something isn't working labels Jun 4, 2024
@ppebay
Copy link
Contributor Author

ppebay commented Jun 4, 2024

Putting this issue on the back burner until it arises again. Until then we can safely ignore it for now.

@ppebay ppebay removed the Low priority To be addressed after high priority label Jul 13, 2024
@ppebay
Copy link
Contributor Author

ppebay commented Jul 13, 2024

Putting this issue on the back burner until it arises again. Until then we can safely ignore it for now.

Bringing this issue to the fore again, as it is confirmed as happening again with the same OS but with VTK-9.3.1 this time:

output_file0

@ppebay
Copy link
Contributor Author

ppebay commented Jul 13, 2024

@lifflander @tlamonthezie please let me know if you are able to reproduce this error on other macOS systems, thanks.

@ppebay
Copy link
Contributor Author

ppebay commented Sep 22, 2024

Update with VTK v9.3.1:

Still with Mac OS Sonoma 14.3, the same incorrect artifacts (for the edge lines) persist, as described previously with 9.3.0:

lb_test7

@tlamonthezie
Copy link
Contributor

tlamonthezie commented Sep 24, 2024

Hello @ppebay to test your configuration a new branch has been created to run this conf in CI

  • macOS 14
    CMAKE_C_COMPILER:FILEPATH=/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
    CMAKE_CXX_COMPILER:FILEPATH=/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++

  • VTK 9.3.1 build from source (no specific compilation flags except CMAKE_BUILD_TYPE:STRING=Release)

  • VT-TV build from source (using build.sh script)

  • execute VT-TV using the standalone app and using config/conf.yaml config file
    It appears that in that configuration the rendering is not as on your side
    Phase 7 rendering is:
    lb_test7

The MACOS test environment is defined at https://github.com/DARMA-tasking/vt-tv/blob/70-incorrectly-generated-png-artifacts/.github/workflows/70-incorrectly-generated-png-artifacts.yml

@ppebay
Copy link
Contributor Author

ppebay commented Sep 27, 2024

Hello @ppebay to test your configuration a new branch has been created to run this conf in CI

  • macOS 14
    CMAKE_C_COMPILER:FILEPATH=/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
    CMAKE_CXX_COMPILER:FILEPATH=/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
  • VTK 9.3.1 build from source (no specific compilation flags except CMAKE_BUILD_TYPE:STRING=Release)
  • VT-TV build from source (using build.sh script)
  • execute VT-TV using the standalone app and using config/conf.yaml config file
    It appears that in that configuration the rendering is not as on your side
    Phase 7 rendering is:
    lb_test7

The MACOS test environment is defined at https://github.com/DARMA-tasking/vt-tv/blob/70-incorrectly-generated-png-artifacts/.github/workflows/70-incorrectly-generated-png-artifacts.yml

Thank you @tlamonthezie for having tested on your side, and confirmed you don't have the issue. It's good that it's now in CI as well. I can't find the corresponding PR for this addition to the CI, is there one?

That said I would still like to be able to reproduce the problem I am seeing, but elsewhere. @maxime-bfsquall can you please confirm that you are getting the same (correct) results as @tlamonthezie above?

@ppebay ppebay changed the title Incorrectly generated PNG artifacts Incorrectly generated PNG artifacts on MacOS Sep 27, 2024
@tlamonthezie
Copy link
Contributor

tlamonthezie commented Sep 27, 2024

Hello @ppebay to test your configuration a new branch has been created to run this conf in CI

  • macOS 14
    CMAKE_C_COMPILER:FILEPATH=/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
    CMAKE_CXX_COMPILER:FILEPATH=/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
  • VTK 9.3.1 build from source (no specific compilation flags except CMAKE_BUILD_TYPE:STRING=Release)
  • VT-TV build from source (using build.sh script)
  • execute VT-TV using the standalone app and using config/conf.yaml config file
    It appears that in that configuration the rendering is not as on your side
    Phase 7 rendering is:
    lb_test7

The MACOS test environment is defined at https://github.com/DARMA-tasking/vt-tv/blob/70-incorrectly-generated-png-artifacts/.github/workflows/70-incorrectly-generated-png-artifacts.yml

Thank you @tlamonthezie for having tested on your side, and confirmed you don't have the issue. It's good that it's now in CI as well. I can't find the corresponding PR for this addition to the CI, is there one?

That said I would still like to be able to reproduce the problem I am seeing, but elsewhere. @maxime-bfsquall can you please confirm that you are getting the same (correct) results as @tlamonthezie above?

Hello @ppebay I think that it is not relevant to keep this test workflow in CI as there are now macos runners doing near the same in the unit tests workflows.
The macos runners (macos 12, 13 and 14) that run in CI are already rendering PNG artifacts

The main difference with the workflow created for the current issue is that the standalone app is run instead of the rendering tests to replay exactly the error scenario but it seems that it does not change anything at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants