-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrectly generated PNG artifacts on MacOS #70
Comments
Test this on a Mac machine @pierrepebay |
Putting this issue on the back burner until it arises again. Until then we can safely ignore it for now. |
@lifflander @tlamonthezie please let me know if you are able to reproduce this error on other macOS systems, thanks. |
Hello @ppebay to test your configuration a new branch has been created to run this conf in CI
The MACOS test environment is defined at https://github.com/DARMA-tasking/vt-tv/blob/70-incorrectly-generated-png-artifacts/.github/workflows/70-incorrectly-generated-png-artifacts.yml |
Thank you @tlamonthezie for having tested on your side, and confirmed you don't have the issue. It's good that it's now in CI as well. I can't find the corresponding PR for this addition to the CI, is there one? That said I would still like to be able to reproduce the problem I am seeing, but elsewhere. @maxime-bfsquall can you please confirm that you are getting the same (correct) results as @tlamonthezie above? |
Hello @ppebay I think that it is not relevant to keep this test workflow in CI as there are now macos runners doing near the same in the unit tests workflows. The main difference with the workflow created for the current issue is that the standalone app is run instead of the rendering tests to replay exactly the error scenario but it seems that it does not change anything at the end. |
Steps to reproduce
test-vt-tv.yaml
configuration file in order to exercise vt-tv.Observed error
Incorrect and missing edges in PNG artifact:
The text was updated successfully, but these errors were encountered: