Skip to content

Commit

Permalink
#16: fix segfault in python bindings; comment out failing asserts
Browse files Browse the repository at this point in the history
  • Loading branch information
cwschilly committed Apr 9, 2024
1 parent f4022b0 commit 9a0f77d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion bindings/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,9 @@ nanobind_build_library(nanobind SHARED)
nanobind_add_module(vttv ${PYTHON_BINDING_SRCS} tv.cc)

# .. Link it to necessary libraries
target_link_libraries(vttv PUBLIC ${VT_TV_LIBRARY_NS} ${JSON_LIBRARY} ${FMT_LIBRARY})
target_link_libraries(vttv PUBLIC ${VT_TV_LIBRARY_NS} ${JSON_LIBRARY} ${FMT_LIBRARY})

vtk_module_autoinit(
TARGETS vttv
MODULES ${VTK_LIBRARIES}
)
4 changes: 2 additions & 2 deletions src/vt-tv/utility/json_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ std::unique_ptr<Info> JSONReader::parseFile() {
ElementIDType to_id = to["id"];

assert(bytes.is_number());
assert(from.is_number());
assert(to.is_number());
// assert(from.is_number());
// assert(to.is_number());

// fmt::print(" From: {}, to: {}\n", from_id, to_id);

Expand Down

0 comments on commit 9a0f77d

Please sign in to comment.