Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16: use external fmt #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

#16: use external fmt #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1a682e
#16: depend on fmt and use external fmt
nmm0 Jun 6, 2024
7d4f0cd
#16: constrain when fmt is used as a dependency
nmm0 Jun 25, 2024
669d1ad
#16: only add external fmt on 1.5 or later
nmm0 Jun 25, 2024
911f0d9
#16: install unzip since external fmt needs it
nmm0 Aug 22, 2024
23cecb9
#16: update apt first
nmm0 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_spack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ jobs:

- name: Prepare Spack configuration
run: |
apt update && apt install unzip
mkdir -p /github/home/.spack/
cp ci/packages.yaml /github/home/.spack/

chmod +x ci/test_spack.sh

mkdir ./kokkos_enabled
Expand Down
4 changes: 4 additions & 0 deletions packages/darma-vt/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ class DarmaVt(CMakePackage):
depends_on("mpi")
depends_on("darma-magistrate+kokkos", when="+kokkos")
depends_on("darma-magistrate~kokkos", when="~kokkos")
depends_on("fmt", when="@develop,1.5:")

sanity_check_is_dir = ["include/vt"]
sanity_check_is_file = ["cmake/vtConfig.cmake", "cmake/vtTargets.cmake"]
Expand Down Expand Up @@ -211,6 +212,9 @@ def cmake_args(self):
),
]

if self.spec.version >= Version("1.5.0"):
args.append("-Dvt_external_fmt=ON")

if self.spec.version > Version("1.3.0"):
build_tests_arg = "-Dvt_build_tests={}".format(
int(self.spec.variants["build_tests"].value)
Expand Down
Loading