Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional Kokkos support to magistrate #21

Closed
cz4rs opened this issue Aug 1, 2024 · 0 comments · Fixed by #22
Closed

add optional Kokkos support to magistrate #21

cz4rs opened this issue Aug 1, 2024 · 0 comments · Fixed by #22
Assignees

Comments

@cz4rs
Copy link

cz4rs commented Aug 1, 2024

distBVH uses spack packages in CI and it fails when attempting to serialize Kokkos::View:

/opt/view/include/checkpoint/dispatch/dispatch_serializer_nonbyte.h:233:16: error: no matching function for call to 'checkpoint::dispatch::SerializerDispatchNonByte<checkpoint::Sizer, Kokkos::View<unsigned char*, Kokkos::LayoutRight, Kokkos::OpenMP>, checkpoint::dispatch::BasicDispatcher<checkpoint::Sizer, Kokkos::View<unsigned char*, Kokkos::LayoutRight, Kokkos::OpenMP> > >::applyStatic(checkpoint::Sizer&, Kokkos::View<unsigned char*, Kokkos::LayoutRight, Kokkos::OpenMP>*&, checkpoint::SerialSizeType&)'

TODO:
Add Kokkos as an optional dependency and corresponding variant (default=False) to magistrate package.

magistrate enables Kokkos support based on existence of Kokkos_DIR or Kokkos_ROOT, so I'm assuming something like "-DKokkos_ROOT={}".format(self.spec["kokkos"].prefix) will be necessary.

@JacobDomagala JacobDomagala linked a pull request Aug 1, 2024 that will close this issue
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
JacobDomagala added a commit that referenced this issue Aug 2, 2024
@nmm0 nmm0 closed this as completed in #22 Aug 7, 2024
nmm0 added a commit that referenced this issue Aug 7, 2024
…ort-to-magistrate

#21: Add Kokkos dependency for magistrate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants