Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#303: use gtest imported targets #304

Merged
merged 2 commits into from
Jun 6, 2023
Merged

#303: use gtest imported targets #304

merged 2 commits into from
Jun 6, 2023

Conversation

nmm0
Copy link
Contributor

@nmm0 nmm0 commented May 9, 2023

Fixes #303

@nmm0 nmm0 mentioned this pull request May 9, 2023
Open
@nmm0 nmm0 force-pushed the 303-use-gtest-imported-targets branch from 471744c to 6d00dcd Compare June 1, 2023 22:54
cz4rs
cz4rs approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the leftover variable.

@nlslatt nlslatt merged commit 87f1ab4 into develop Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@cz4rs cz4rs cz4rs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GTest imported targets
4 participants
@nmm0 @PhilMiller @cz4rs @nlslatt