Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#249: Non-Intrusive examples and docs #259

Merged
merged 6 commits into from
Oct 25, 2022
Merged

#249: Non-Intrusive examples and docs #259

merged 6 commits into from
Oct 25, 2022

Conversation

thearusable
Copy link
Contributor

Closes #249

@thearusable thearusable self-assigned this Jul 26, 2022
@thearusable thearusable force-pushed the 249-non-intrusive-examples-and-docs branch from 7d599a5 to 290b720 Compare July 26, 2022 11:04
@thearusable thearusable marked this pull request as ready for review July 26, 2022 11:41
@nmm0 nmm0 mentioned this pull request Jul 26, 2022
Open
@thearusable thearusable force-pushed the 249-non-intrusive-examples-and-docs branch from 290b720 to 9643222 Compare September 12, 2022 16:00
@nlslatt nlslatt force-pushed the 249-non-intrusive-examples-and-docs branch from 9643222 to fe9358b Compare October 19, 2022 18:47
cz4rs
cz4rs reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, I'm going to give it another look after the weekend.
Some nitpicking remarks about the comments, but I don't feel like these have to be addressed.

examples/checkpoint_example_polymorphic_macro_nonintrusive.cc Outdated Show resolved Hide resolved
examples/checkpoint_example_to_file_nonintrusive.cc Outdated Show resolved Hide resolved
examples/checkpoint_example_to_file_nonintrusive.cc Show resolved Hide resolved
examples/checkpoint_example_2_nonintrusive.cc Show resolved Hide resolved
@thearusable thearusable requested a review from cz4rs October 25, 2022 09:31
@PhilMiller PhilMiller force-pushed the 249-non-intrusive-examples-and-docs branch from 11fa3be to 47b1a33 Compare October 25, 2022 20:44
@PhilMiller PhilMiller merged commit beaf39c into develop Oct 25, 2022
@PhilMiller PhilMiller deleted the 249-non-intrusive-examples-and-docs branch October 25, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@nlslatt nlslatt Awaiting requested review from nlslatt

@nmm0 nmm0 Awaiting requested review from nmm0

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve non-intrusive serialization documentation and examples
3 participants
@thearusable @PhilMiller @cz4rs