#573: verified that no bug is actually present but made stylistic changes

src/lbaf/IO/lbsVTDataReader.py

@@ -55,7 +55,7 @@
 from ..Model.lbsObjectCommunicator import ObjectCommunicator
 from ..Model.lbsRank import Rank
 
 class LoadReader:
     """A class to read VT Object Map files. These json files could be compressed with Brotli.
 
     Each file is named as <base-name>.<node>.json, where <node> spans the number of MPI ranks that VT is utilizing.
@@ -134,9 +134,9 @@
 
     def _get_n_ranks(self):
         """Determine the number of ranks automatically.
-
-        This use the first applicable method in the following methods:
-        List all data file names matching {file_prefix}.{rank_id}.{file_suffix} pattern and return max(rank_id) + 1.
+        This uses the first applicable method in the following methods:
+        List all data file names matching {file_prefix}.{rank_id}.{file_suffix}
+        pattern and return max(rank_id) + 1.
         """
 
         # or default detect data files with pattern
@@ -199,7 +199,7 @@
         # Return rank ID and data dictionary
         return rank_id, decompressed_dict
 
     def _populate_rank(self, phase_id: int, rank_id: int) -> Tuple[Rank,dict]:
         """ Populate rank and its communicator in phase using the JSON content."""
 
         # Seek phase with given ID
@@ -224,9 +224,9 @@
         self.__logger.debug(
             f"Loading phase {curr_phase_id} for rank {rank_id}")
 
-        # Add communications to the object
+        # Add communications when available
         rank_comm = {}
-        if (communications := phase.get("communications")): # pylint:disable=W0631:undefined-loop-variable
+        if (communications := phase.get("communications")):
             if phase_id in self.__communications_dict:
                 self.__communications_dict[phase_id][rank_id] = communications
             else:
@@ -263,6 +263,7 @@
                         for k, v in comm.items():
                             self.__logger.debug(f"{k}: {v}")
         else:
+            # No communications for this phase
             self.__communications_dict.setdefault(phase_id, {rank_id: {}})
 
         # Instantiante rank for current phase
@@ -273,11 +274,11 @@
         rank_blocks, task_user_defined = {}, {}
 
         # Iterate over tasks
-        for task in phase.get("tasks", []): # pylint:disable=W0631:undefined-loop-variable
+        for task in phase.get("tasks", []):
             # Retrieve required values
             task_entity = task.get("entity")
-            task_id = task_entity.get("id", None)
-            task_seq_id = task_entity.get("seq_id", None)
+            task_id = task_entity.get("id")
+            task_seq_id = task_entity.get("seq_id")
             task_load = task.get("time")
             task_user_defined = task.get("user_defined", {})
             subphases = task.get("subphases")
@@ -338,7 +339,7 @@
         # Returned rank and communicators per phase
         return phase_rank, rank_comm
 
     def populate_phase(self, phase_id: int) -> List[Rank]:
         """ Populate phase using the JSON content."""
 
         # Create storage for ranks