Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

558 Add optional node-level memory constraint instead of rank-level constraint to loosen #559

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

lifflander
Copy link
Contributor

Fixes #558

@lifflander lifflander linked an issue Oct 21, 2024 that may be closed by this pull request
@lifflander lifflander marked this pull request as draft October 21, 2024 21:45
@lifflander lifflander changed the title Add optional node-level memory constraint instead of rank-level constraint to loosen 558 Add optional node-level memory constraint instead of rank-level constraint to loosen Oct 23, 2024
@ppebay
Copy link
Contributor

ppebay commented Dec 9, 2024

@lifflander we seem to have a confusion between the two types of object ids/indices now:

[LBAF_app] Writing single phase 0 to JSON files
multiprocessing.pool.RemoteTraceback: 
"""
Traceback (most recent call last):
  File "/Users/pppebay/miniconda3/envs/lbaf39/lib/python3.9/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/IO/lbsVTDataWriter.py", line 279, in _json_writer
    serial_json = self._json_serializer(rank_phases_double)
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/IO/lbsVTDataWriter.py", line 251, in _json_serializer
    self.__create_tasks(
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/IO/lbsVTDataWriter.py", line 126, in __create_tasks
    if o.get_index() is not None:
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/Model/lbsObject.py", line 184, in get_index
    return self.__index
AttributeError: 'Object' object has no attribute '_Object__index'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/Applications/LBAF_app.py", line 693, in <module>
    LBAFApplication().run()
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/Applications/LBAF_app.py", line 623, in run
    self.__json_writer.write(
  File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/IO/lbsVTDataWriter.py", line 316, in write
    for file_name in results:
  File "/Users/pppebay/miniconda3/envs/lbaf39/lib/python3.9/multiprocessing/pool.py", line 870, in next
    raise value
AttributeError: 'Object' object has no attribute '_Object__index'

This should be resolved by PR #565 @lifflander

@ppebay
Copy link
Contributor

ppebay commented Dec 17, 2024

Assigning @cwschilly to resolve the issues caused by the recent merges Tx

@cwschilly cwschilly force-pushed the 558-add-node-level-memory-constraint branch from 03db9bc to ce5ef80 Compare December 17, 2024 16:03
Comment on lines +200 to +204
l_try = abs(r_try.get_load() + objects_load - ave_load)
if l_try < l_dst:
c_dst, r_dst, l_dst = c_try, r_try, l_try
elif l_try == l_dst and c_try > c_dst:
c_dst, r_dst = c_try, r_try
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we handle the else condition of this block? (There is a pylint error because r_dst might not be defined)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add node-level memory constraint
3 participants