-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
558 Add optional node-level memory constraint instead of rank-level constraint to loosen #559
base: develop
Are you sure you want to change the base?
Conversation
@lifflander we seem to have a confusion between the two types of object ids/indices now:
This should be resolved by PR #565 @lifflander |
Assigning @cwschilly to resolve the issues caused by the recent merges Tx |
03db9bc
to
ce5ef80
Compare
l_try = abs(r_try.get_load() + objects_load - ave_load) | ||
if l_try < l_dst: | ||
c_dst, r_dst, l_dst = c_try, r_try, l_try | ||
elif l_try == l_dst and c_try > c_dst: | ||
c_dst, r_dst = c_try, r_try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we handle the else
condition of this block? (There is a pylint error because r_dst
might not be defined)
Fixes #558