Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#547: Add tests for new PrescribedPermutation algorithm #548

Merged

Conversation

cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Sep 25, 2024

Fixes #547

Cases tested in this PR:

  • load-only: W_max=2.0
  • off-node-communication-only: W_max=0.0

This PR makes the same changes as #541 to write out w_max.txt when we run LBAF.

I also altered the LBAFApplication.run() function so that we can call it directly from tests with a configuration dict. This allows us to:

  1. avoid using subprocess.run() to call LBAF
  2. avoid having to create separate configuration files for each test case

Now we can run LBAF in tests with:

        # Run LBAF
        lbaf = LBAFApplication()
        lbaf.run(cfg=config, cfg_dir=acceptance_dir)

@cwschilly cwschilly linked an issue Sep 25, 2024 that may be closed by this pull request
@cwschilly cwschilly requested review from ppebay, tlamonthezie, lifflander and nlslatt and removed request for ppebay September 25, 2024 16:50
@cwschilly cwschilly self-assigned this Sep 25, 2024
@cwschilly cwschilly merged commit a245a02 into develop Sep 26, 2024
14 checks passed
@cwschilly cwschilly deleted the 547-add-tests-for-new-prescribedpermutation-algorithm branch September 26, 2024 16:54
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
* #547: add tests for permutation algorithm

* #547: remove accidental addition

* #547: add capability to call lbaf.run directly

* #547: remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for new PrescribedPermutation algorithm
2 participants