Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#419: Modify deploy_docs.yml to correctly push documentation #459

Merged
merged 7 commits into from
Oct 13, 2023
Merged

#419: Modify deploy_docs.yml to correctly push documentation #459

merged 7 commits into from
Oct 13, 2023

Conversation

cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Oct 10, 2023 •
edited
Loading

Fixes #419

Documentation for JamesIves/github-pages-deploy-action is found here.

@cwschilly cwschilly linked an issue Oct 10, 2023 that may be closed by this pull request
Modify deploy_docs.yml to correctly push documentation #419
Closed
@cwschilly cwschilly marked this pull request as draft October 10, 2023 17:48
@cwschilly cwschilly self-assigned this Oct 10, 2023
@cwschilly cwschilly mentioned this pull request Oct 12, 2023
Merged
@cwschilly cwschilly marked this pull request as ready for review October 12, 2023 17:19
@cwschilly
Copy link
Contributor Author

To test, I changed the target branch and deployed the docs from this PR. If this looks correct, we are good to merge this in (I have changed the target branch back to the original).

ppebay
ppebay approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@cwschilly cwschilly merged commit f648748 into develop Oct 13, 2023
@cwschilly cwschilly deleted the 419-modify-deploy_docsyml-to-correctly-push-documentation branch October 13, 2023 15:30
cwschilly added a commit that referenced this pull request Oct 19, 2023
@cwschilly
#419: Modify deploy_docs.yml to correctly push documentation (#459)
38c7dd5 
* #419: modify deploy_docs.yml

* #419: add newline

* #419: change target branch to test workflow

* #419: fix pip install

* #419: explicitly install necessary packages

* #419: download json files validator

* #419: return to original target branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppebay ppebay ppebay approved these changes

@lifflander lifflander Awaiting requested review from lifflander

Assignees

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify deploy_docs.yml to correctly push documentation
2 participants
@cwschilly @ppebay